place_of_birth -> birthplace

Comments (17)

1. 

   Travis Spencer reporter

   • changed component to Assurance

   • 2019-10-18T17:07:05+00:00
2. 

   Michael Jones

   “birthplace” is shorter and an actual English word, so this seems like a reasonable change.

   • 2019-10-24T14:37:43+00:00
3. 

   gffletch

   I agree, this makes sense to me

   • 2019-10-24T14:38:16+00:00
4. 

   Michael Jones

   • assigned issue to
     
     Torsten Lodderstedt

   • 2019-10-24T15:43:12+00:00
5. 

   Takahiko Kawasaki

   @Torsten Lodderstedt I created a pull request #3 for this purpose. If the WG accepts the change, please review the pull request and merge it if it is okay.

   • 2020-01-15T12:17:49+00:00
6. 

   Torsten Lodderstedt

   • changed status to open

   PR exists

   • 2020-01-25T11:53:52+00:00
7. 

   Torsten Lodderstedt

   Note: this is a breaking change. Is it worth the impact for existing implementations? If so, how do we support existing implementations in the migration process? Or shall we enable OPs to support different versions of our spec?

   • 2020-01-28T04:48:20+00:00
8. 

   Takahiko Kawasaki

   I personally have no strong opinion as to whether the claim name should be changed to birthplace or not although I have submitted the pull request #3.

   • 2020-01-28T06:30:26+00:00
9. 

   Torsten Lodderstedt

   Discussion in the call today:

   • place of birth is the term used in ICAO 93.3 (part 3), which is the international standard for travel/id documents. That’s a good reason to stick to place_of_birth
   • If we nevertheless decide, we need a version management concept, since this a breaking change.

   ‌

   • 2020-01-29T16:11:21+00:00
10. 

    Achim Schlosser

    Revisiting this after the call - a good argument why this should be changed:

    • ICAO 93.3 (part 3) does use the wording “Place of birth“, having that said ICAO 93.3 also uses “Date of birth“ in its definition.
    • OIDC core (https://openid.net/specs/openid-connect-core-1_0.html#ClaimsContents) defines birthdate instead of “Date of birth“ (which poses a similar question)
    • From an OIDC perspective the use of birthplace seems to the sensible choice in term of consistency of the overall specification, using a different “syntax“ here looks rather strange

    ‌

    • 2020-01-30T08:22:33+00:00
11. 

    Achim Schlosser

    Putting it side by side (from the claims / evidence ticket) "claims":["birthdate","place_of_birth"] makes the point obvious

    • 2020-01-30T08:25:02+00:00
12. 

    Torsten Lodderstedt

    • changed milestone to Implementer's Draft 2
    • removed component

    • 2020-02-18T09:46:13+00:00
13. 

    Torsten Lodderstedt

    • removed milestone

    • 2020-02-26T15:56:01+00:00
14. 

    Torsten Lodderstedt

    • changed milestone to next stage

    • 2020-03-04T15:48:11+00:00
15. 

    Torsten Lodderstedt

    • changed milestone to next stage (candidates)

    • 2020-03-04T15:55:26+00:00
16. 

    Mark Haine

    Co-chairs decided that this should be closed for two reasons:

    1. this is a breaking change and there are implementations already
    2. there were no strong opions voiced at WG meetings

    ‌

    • 2020-05-05T05:08:34+00:00
17. 

    Mark Haine

    • changed status to resolved

    reasons noted in comments section

    • 2020-05-05T05:08:53+00:00
18. Log in to comment