Reporting Issues
Bug 1521 - Add CET feature support in SMM
Summary: Add CET feature support in SMM
Status: RESOLVED FIXED
Alias: None
Product: EDK2
Classification: Unclassified
Component: Code (show other bugs)
Version: Current
Hardware: All All
: Lowest normal
Assignee: Kuo, Donald
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-11 23:33 UTC by Kuo, Donald
Modified: 2019-03-18 00:07 UTC (History)
7 users (show)

See Also:
EDK II Code First industry standard specifications: ---
Branch URL:
Release(s) the issue is observed: UDK 2018
The OS the target platform is running: ---
Package: UefiCpuPkg
Release(s) the issues must be fixed: EDK II Master
Tianocore documents:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kuo, Donald 2019-02-11 23:33:38 UTC
Add CET feature support in SMM
Comment 2 Laszlo Ersek 2019-02-12 04:11:16 UTC
Section "8.2 Feature Enumeration" explains the CPUID leaves / bits that advertize the related features.

If you rely on CPUID, and conditional jumps, in such assembly code that runs either in 16-bit mode SMM, or is otherwise related to processor mode switching, please be aware that jumps in such contexts may crash on QEMU.

See for example commit 8d4d55b15b58 ("UefiCpuPkg/PiSmmCpuDxeSmm: eliminate conditional jump in IA32 SmmStartup()", 2018-01-31).

When you post the series to edk2-devel, please be sure to CC all the maintainers and reviewers listed for UefiCpuPkg in the Maintainers.txt file.

Thanks!
Comment 3 jiewen.yao 2019-02-12 07:41:39 UTC
Some early code is at https://github.com/jyao1/edk2/tree/CET.

They are validated on Qemu, which does not have CET support.

The final version will be updated after new document publish.
Comment 4 nobody 2019-03-18 00:07:31 UTC
Fix it at edk2 68edd7dbad77d7170ee0e1c5dbefae93ea9997b1..3eb69b081c683f9d825930d0c511e43c0485e5d2