Reporting Issues
Bug 2522 - Adopt VariablePolicy, Deprecate VarLock and VarCheckPolicy.
Summary: Adopt VariablePolicy, Deprecate VarLock and VarCheckPolicy.
Status: RESOLVED FIXED
Alias: None
Product: Tianocore Feature Requests
Classification: Unclassified
Component: Code (show other bugs)
Version: Current
Hardware: All All
: Lowest normal
Assignee: Bret Barkelew
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-11 19:45 UTC by Bret Barkelew
Modified: 2020-11-25 15:36 UTC (History)
5 users (show)

See Also:
EDK II Code First industry standard specifications: ---
Branch URL:
Release(s) the issue is observed:
The OS the target platform is running: ---
Package: MdeModulePkg
Release(s) the issues must be fixed:
Tianocore documents:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bret Barkelew 2020-02-11 19:45:03 UTC
VariablePolicy is a proposal for an expanded “VarLock-like” interface to constrain and govern platform variables.
Full details can be found in the RFC email on the RFC and Devel mailing lists (subject: "[RFC] VariablePolicy - Protocol, Libraries, and Implementation for VariableLock Alternative").

This BZ is being used to track the patches, discussion, and final adoption.

Thanks!
Comment 1 Bret Barkelew 2020-02-11 19:57:34 UTC
Have started breaking the RFC up into code review patches in this branch:
https://github.com/corthon/edk2/tree/personal/brbarkel/var_policy_dev_submission
Comment 2 nobody 2020-02-20 20:25:33 UTC
Bret, please take it.
Comment 3 nobody 2020-03-19 01:21:15 UTC
Bret is driving it.
Comment 4 Bret Barkelew 2020-03-19 14:29:38 UTC
Liming,
What's the next step? Start attaching patches?

I'm going to email the edk2-platform maintainers today.
Comment 5 Bret Barkelew 2020-04-10 14:44:24 UTC
v1 patches can be found here:
https://edk2.groups.io/g/devel/message/57217
Comment 6 Bret Barkelew 2020-05-21 17:50:18 UTC
v4 of patches will be going out the mailing list, the TC wiki is updated with platform instructions, and all edk2-platform maintainers have been informed.
Comment 7 Michael Kubacki 2020-05-21 18:47:37 UTC
(In reply to Bret Barkelew from comment #6)
> v4 of patches will be going out the mailing list, the TC wiki is updated
> with platform instructions, and all edk2-platform maintainers have been
> informed.

v3 patch series is on the list - https://edk2.groups.io/g/devel/message/60070

Bret, I think the list version is one behind what you're tracking on your fork.
Comment 8 Bret Barkelew 2020-05-21 20:00:50 UTC
Agreed. v3 it is.
Comment 9 Laszlo Ersek 2020-09-23 04:55:56 UTC
Summary of patch set versions:

* [edk2-devel] [PATCH v1 0/9] Add the VariablePolicy feature
http://mid.mail-archive.com/MWHPR07MB3440C61EDC28D3447901CAEAE9DE0@MWHPR07MB3440.namprd07.prod.outlook.com
https://edk2.groups.io/g/devel/message/57217

* [edk2-devel] [PATCH v2 00/12] Add the VariablePolicy feature
http://mid.mail-archive.com/MWHPR07MB3440F5CB92F0D7DCF94AA14FE9BE0@MWHPR07MB3440.namprd07.prod.outlook.com
https://edk2.groups.io/g/devel/message/59233

* [edk2-devel] [PATCH v3 00/14] Add the VariablePolicy feature
http://mid.mail-archive.com/MWHPR07MB344099884131EEBACE77E6D9E9B70@MWHPR07MB3440.namprd07.prod.outlook.com
https://edk2.groups.io/g/devel/message/60070

* [edk2-devel] [PATCH v4 00/14] Add the VariablePolicy feature
http://mid.mail-archive.com/20200601163310.1718-1-brbarkel@microsoft.com
https://edk2.groups.io/g/devel/message/60528

* [edk2-devel] [PATCH v5 00/14] Add the VariablePolicy feature
http://mid.mail-archive.com/20200603065810.806-1-brbarkel@microsoft.com
https://edk2.groups.io/g/devel/message/60651

* [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature
http://mid.mail-archive.com/20200623064104.1908-1-brbarkel@microsoft.com
https://edk2.groups.io/g/devel/message/61593

* [edk2-devel] [PATCH v7 00/14] Add the VariablePolicy feature
http://mid.mail-archive.com/20200828055127.1610-1-brbarkel@microsoft.com
https://edk2.groups.io/g/devel/message/64712

* [edk2-devel] [PATCH v8 00/14] Add the VariablePolicy feature
http://mid.mail-archive.com/20200923060748.3795-1-bret.barkelew@microsoft.com
https://edk2.groups.io/g/devel/message/65494
Comment 10 gaoliming 2020-11-16 20:01:12 UTC
PR https://github.com/tianocore/edk2/pull/1128 is created.
Comment 11 Laszlo Ersek 2020-11-17 13:15:36 UTC
(In reply to gaoliming from comment #10)
> PR https://github.com/tianocore/edk2/pull/1128 is created.

Commit range: d448574e7310..124b3f9289f1.
Comment 13 Laszlo Ersek 2020-11-25 15:36:02 UTC
Note: commit 355b181f7405 ("MdeModulePkg: Define the VariablePolicyLib", 2020-11-17) may cause a regression at OS runtime; see BZ 3092 for details.