UnitTestFrameworkPkg\Library\UnitTestLib\RunTests.c line 37 Suspicious dereference of pointer 'Suite' before NULL check at line 39 UnitTestFrameworkPkg\Library\UnitTestLib\RunTestsCmocka.c line 439 Suspicious dereference of pointer 'Suite' before NULL check at line 444
Assigned to Liming
Guomin will check it.
(In reply to shenglei.zhang from comment #0) > UnitTestFrameworkPkg\Library\UnitTestLib\RunTests.c line 37 > Suspicious dereference of pointer 'Suite' before NULL check at line 39 > > UnitTestFrameworkPkg\Library\UnitTestLib\RunTestsCmocka.c line 439 > Suspicious dereference of pointer 'Suite' before NULL check at line 444 RunTestsCmocka.c should be UnitTestLib.c.
UnitTestLib.c seem ok in the newest master, could you double check it.
(In reply to newexplorerj from comment #4) > UnitTestLib.c seem ok in the newest master, could you double check it. I think the issue still exists. We can fix this issue through below change. if ((Suite == NULL) || (Description == NULL) || (Name == NULL) || (Function == NULL)) { return EFI_INVALID_PARAMETER; } ParentFramework = (UNIT_TEST_FRAMEWORK *)Suite->ParentFramework;
Change subject and add missing change, post patch v2 at https://edk2.groups.io/g/devel/message/55476.
Fixed at https://github.com/tianocore/edk2/commit/5bc09cf05a98784d483d9bb9d95a65f14eadb5f6