Reporting Issues
Bug 2841 - Add capability to let PEIM extend TcgEvent
Summary: Add capability to let PEIM extend TcgEvent
Status: RESOLVED FIXED
Alias: None
Product: Tianocore Feature Requests
Classification: Unclassified
Component: Code (show other bugs)
Version: Current
Hardware: All All
: Lowest normal
Assignee: qi1.zhang@intel.com
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-06 01:30 UTC by jiewen.yao
Modified: 2020-08-14 01:42 UTC (History)
3 users (show)

See Also:
EDK II Code First industry standard specifications: ---
Branch URL:
Release(s) the issue is observed:
The OS the target platform is running: ---
Package: SecurityPkg
Release(s) the issues must be fixed:
Tianocore documents:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jiewen.yao 2020-07-06 01:30:06 UTC
Currently, we have TCG/TCG2 protocol and DxeTpmMeasurementLib to let DXE module extend the TCG event.

There is more and more use case in PEI phase that a PEIM need extend TCG event, such as BootGuard, FSP, Microcode measurement. Currently, we dont have API to do that so that each module need create TCG/TCG2 event log, which is a burden.

This bugzilla requests to add PeiTpmMeasurementLib instance.

The implementation includes:
1) A EDKII_TCG_PPI which abstracts the HashLogExtendEvent service.
2) A PeiTpmMeasurementLib instance, so that a PEIM can call this API to add TCG event.
3) Add more API in TpmMeasurementLib, such as MeasureFirmwareBlob, MeasureHandoffTable for TPM PFP rev 105 support - add description for the FirmwareBlob and HandoffTable.
Comment 1 jiewen.yao 2020-07-06 01:33:32 UTC
Sample implementation is at https://github.com/jyao1/edk2/tree/FspManifest
Comment 2 ydong10 2020-07-07 21:40:31 UTC
Reasonable request
Comment 3 qi1.zhang@intel.com 2020-07-14 20:31:14 UTC
https://edk2.groups.io/g/devel/message/62486
Comment 4 qi1.zhang@intel.com 2020-07-16 20:44:13 UTC
v2:
https://edk2.groups.io/g/devel/message/62693
Comment 5 qi1.zhang@intel.com 2020-07-19 22:50:30 UTC
v4:
https://edk2.groups.io/g/devel/message/62759
Comment 6 qi1.zhang@intel.com 2020-07-21 22:43:16 UTC
Move this requirement to https://bugzilla.tianocore.org/show_bug.cgi?id=2376

3) Add more API in TpmMeasurementLib, such as MeasureFirmwareBlob, MeasureHandoffTable for TPM PFP rev 105 support - add description for the FirmwareBlob and HandoffTable.
Comment 7 jiewen.yao 2020-07-22 21:46:34 UTC
check in b630feee025564f794599f1f514aa4ac7f0a0c63..b87f31f034340c73ca072b65386f58c8ca1bc87b
Comment 8 nobody 2020-08-14 01:42:08 UTC
This belongs to new feature.