Reporting Issues
Bug 3454 - Spellcheck plugin finds fewer files when run on Linux
Summary: Spellcheck plugin finds fewer files when run on Linux
Status: RESOLVED FIXED
Alias: None
Product: EDK2
Classification: Unclassified
Component: Code (show other bugs)
Version: Current
Hardware: All All
: Lowest normal
Assignee: kun.qin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-11 18:51 UTC by Sean Brogan
Modified: 2021-07-11 03:25 UTC (History)
3 users (show)

See Also:
EDK II Code First industry standard specifications: ---
Branch URL:
Release(s) the issue is observed: EDK II Master
The OS the target platform is running: ---
Package: N/A
Release(s) the issues must be fixed: EDK II Master
Tianocore documents:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Brogan 2021-06-11 18:51:39 UTC
When spellcheck plugin invokes cspell to check files it uses a wildcard path like <package>/**/*.h.  On Linux this is expanded by the shell therefore doesn't pick up the expected files (fewer files).  

To resolve double quote the path so that the shell doesn't expand and the parameter is passed to cspell to expand.
Comment 1 kun.qin 2021-06-12 01:06:04 UTC
Patch sent for review: https://edk2.groups.io/g/devel/message/76428

PR created here: https://github.com/tianocore/edk2/pull/1706
Comment 2 kun.qin 2021-06-12 01:06:04 UTC
Patch sent for review: https://edk2.groups.io/g/devel/message/76428

PR created here: https://github.com/tianocore/edk2/pull/1706
Comment 3 kun.qin 2021-06-15 12:55:18 UTC
v2 patch sent here: https://edk2.groups.io/g/devel/message/76553
Comment 4 gaoliming 2021-06-15 21:33:37 UTC
The patch has been sent.
Comment 5 kun.qin 2021-06-23 02:55:21 UTC
(In reply to gaoliming from comment #4)
> The patch has been sent.

Patch reviewed: https://edk2.groups.io/g/devel/message/76636. Still need to merge.
Comment 6 kun.qin 2021-07-11 03:25:33 UTC
Merged via f47c4676dd1a532b22a059cd036918abd6b0dd11. PR: <https://github.com/tianocore/edk2/pull/1804>