Re: [PATCH v2] OvmfPkg: Don't make APIC MMIO accesses with encryption bit set
<Michael.Roth@...> wrote: While at it, could you please fix your email setup and use 8bit transfer encoding instead of quoted printable? Also, please put me on cc so I don't have to
By Ard Biesheuvel · #118343 ·
Re: [PATCH v2] OvmfPkg: Don't make APIC MMIO accesses with encryption bit set
Tom just noticed another spot where a non-leaf C-bit needs to be cleared (the one mapping the GHCB page). It doesn't affect patch functionality but should be included for completeness of this change,
By Roth, Michael · #118342 ·
[PATCH v2] OvmfPkg: Don't make APIC MMIO accesses with encryption bit set
For the most part, OVMF will clear the encryption bit for MMIO regions, but there is currently one known exception during SEC when the APIC base address is accessed via MMIO with the encryption bit
By Roth, Michael · #118341 ·
Re: [PATCH v3 00/13] Add SmmRelocationLib
I don't have a lot of experience with SMM. I believe Paolo first ported over the support into OVMF and might have more insight? I'll try to take a look at it when I can, but maybe @Abner or @Abdul
By Lendacky, Thomas · #118340 ·
Re: [PATCH v4 13/14] UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLib
Reviewed-by: Gua Guo <gua.guo@...>
By Guo, Gua · #118339 ·
[PATCH v4 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic
This patch is to remove legacy SmBase relocation in PiSmmCpuDxeSmm Driver. The responsibility for SmBase relocation has been transferred to the SmmRelocationInit interface, which now handles the
By Wu, Jiaxin · #118338 ·
[PATCH v4 13/14] UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLib
This patch just includes SmmRelocationLib in UefiPayloadPkg. Cc: Sean Rhodes <sean@...> Cc: James Lu <james.lu@...> Cc: Gua Guo <gua.guo@...> Cc: Ray Ni
By Wu, Jiaxin · #118337 ·
[PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase
This patch is to consume SmmRelocationInit for SmBase Relocation. Cc: Jiewen Yao <jiewen.yao@...> Cc: Gerd Hoffmann <kraxel@...> Cc: Ray Ni <ray.ni@...> Signed-off-by: Jiaxin Wu
By Wu, Jiaxin · #118336 ·
[PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or not
Based on gSmmBaseHobGuid: If gSmmBaseHobGuid found, means SmBase info has been relocated and recorded in the SmBase array. So, this patch check smbase relocation is done or not
By Wu, Jiaxin · #118335 ·
[PATCH v4 10/14] OvmfPkg: Refine SmmAccess implementation
This patch refines the SmmAccess implementation: 1. SmramMap will be retrieved from the gEfiSmmSmramMemoryGuid instead of original from the TSEG Memory Base register. 2. Remove the
By Wu, Jiaxin · #118334 ·
[PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid
In the PiSmmCpuDxeSmm driver, SMRAM allocation for SMI handlers and processor Save State areas was traditionally performed using the Smst->AllocatePages() function during the DXE phase. The
By Wu, Jiaxin · #118333 ·
[PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for OVMF
There are below 2 differences between AMD & OVMF according existing implementation: 1.The mode of the CPU check is different between the AMD & OVMF. OVMF: CpuSaveState->x86.SMMRevId & 0Xffff AMD:
By Wu, Jiaxin · #118332 ·
[PATCH v4 07/14] UefiCpuPkg/SmmRelocationLib: Add library instance for AMD
Due to the definition difference of SMRAM Save State, SmmBase config in SMRAM Save State for AMD is also different. This patch provides the AmdSmmRelocationLib library instance to handle the SMRAM
By Wu, Jiaxin · #118331 ·
[PATCH v4 06/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex
This patch is to remove unnecessary CpuIndex. Cc: Zeng Star <star.zeng@...> Cc: Gerd Hoffmann <kraxel@...> Cc: Rahul Kumar <rahul1.kumar@...> Signed-off-by: Jiaxin Wu
By Wu, Jiaxin · #118330 ·
[PATCH v4 05/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary global variable
This patch aims on mProcessorInfo global variable, which can be defined as local variable in SmmRelocateBases(). With this patch, no need to allocate the memory for all CPUs to store the Processor
By Wu, Jiaxin · #118329 ·
[PATCH v4 04/14] UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allocation
Since SMM relocation is performed serially for each CPU, there is no need to allocate buffers for all CPUs to store the SmBase address in mSmBase and the Rebased flag in mRebased. A defined global
By Wu, Jiaxin · #118328 ·
[PATCH v4 03/14] UefiCpuPkg/SmmRelocationLib: Rename global variables
This patch aims to rename global variables for clearer association with Smm Init, ensuring their names are distinct from those used in the PiSmmCpuDxeSmm Driver. Cc: Zeng Star
By Wu, Jiaxin · #118327 ·
[PATCH v4 02/14] UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib library instance
This patch just separates the smbase relocation logic from PiSmmCpuDxeSmm driver, and moves to the SmmRelocationInit interface. It maintains the original implementation of most functions and leaves
By Wu, Jiaxin · #118326 ·
[PATCH v4 01/14] UefiCpuPkg: Add SmmRelocationLib class
Intel plans to separate the smbase relocation logic from PiSmmCpuDxeSmm driver, and the related behavior will be moved to the new interface defined by the SmmRelocationLib class. The SmmRelocationLib
By Wu, Jiaxin · #118325 ·
[PATCH v4 00/14] Add SmmRelocationLib
PR: https://github.com/tianocore/edk2/pull/5546 Intel plans to separate the smbase relocation logic from PiSmmCpuDxeSmm driver, and the related behavior will be moved to the new interface defined by
By Wu, Jiaxin · #118324 ·