Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFD Enhancement #383

Merged
merged 2 commits into from Jul 22, 2019
Merged

Conversation

SumitAgarwal123
Copy link
Contributor

This document describes design for a few enhancements to BFD in BGP docker.

Proposes enhancement to Packet Tx.
A few display and debug enhancements.

@msftclas
Copy link

msftclas commented May 15, 2019

CLA assistant check
All CLA requirements met.


In current SONiC implementation BFD relies on kernel network stack to switch the BFD packet to next available nexthop when a active nexthop goes down. BFD timers in this case is directly proportional to the time it takes for kernel to get the nexthop down event. Faster the kernel learns active nexthop is down the more aggressive BFD timers can be. In this case it is suggested to configure BFD timer values to have a timeout of atleast 600 msec.

## 3.2 CLI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the user turn off BFD feature for his/her setup? Can it be done through CLI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new change is added in section 8, that should answer your question

@xinliu-seattle xinliu-seattle merged commit 9aac03b into sonic-net:master Jul 22, 2019
rajendra-dendukuri pushed a commit to rajendra-dendukuri/SONiC that referenced this pull request Jul 29, 2019
* BFD Enhancment HLD

* mend
@rck-innovium
Copy link
Collaborator

Today I couldn't find any BFD usage in sonic-swss. Are any SAI BFD APIs planned to be used or is it all managed in control plane?

@SumitAgarwal123
Copy link
Contributor Author

Today I couldn't find any BFD usage in sonic-swss. Are any SAI BFD APIs planned to be used or is it all managed in control plane?

As for now it is managed in control plane.

```

# 7 Scalability
- No of sessions: 64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 64 a hard limit? Do you have any test result for the maximum number of sessions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No 64 it's not a hard limit. We have tested with 64 session but i do not have log to attach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants