Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPLS for SONiC infrastructure HLD #706

Merged
merged 9 commits into from Mar 23, 2022
Merged

Conversation

qbdwlr
Copy link
Contributor

@qbdwlr qbdwlr commented Nov 16, 2020

@microsoft-cla-retired
Copy link

microsoft-cla-retired bot commented Nov 16, 2020

CLA assistant check
All CLA requirements met.

doc/mpls/MPLS_hld.md Outdated Show resolved Hide resolved
@TACappleman
Copy link
Contributor

Hi, My team is also about to start working on coding up MPLS support in SONiC following a similar design to this one. Please could you get in touch with me on Thomas.Cappleman@metaswitch.com so we can coordinate our work?

Regarding this design, there are a couple of additional features we are planning to add. Are these ones you've considered?

  • Popping a label then basing the forwarding decision on the next header (either a following label or IP header). Related to this, popping a label that is associated with a given VRF, then routing within that VRF based on the following IP header.
  • Support for specifying uniform or pipe TTL mode.

doc/mpls/MPLS_hld.md Outdated Show resolved Hide resolved
doc/mpls/MPLS_hld.md Outdated Show resolved Hide resolved
doc/mpls/MPLS_hld.md Outdated Show resolved Hide resolved
doc/mpls/MPLS_hld.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

doc/mpls/MPLS_hld.md Show resolved Hide resolved
doc/mpls/MPLS_hld.md Show resolved Hide resolved
doc/mpls/MPLS_hld.md Outdated Show resolved Hide resolved
doc/mpls/MPLS_hld.md Outdated Show resolved Hide resolved
doc/mpls/MPLS_hld.md Show resolved Hide resolved
doc/mpls/MPLS_hld.md Show resolved Hide resolved
Copy link
Contributor

@rlhui rlhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please add in the doc current limitation for using FRR?

Copy link
Contributor

@rlhui rlhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description for PHP

@rlhui
Copy link
Contributor

rlhui commented Mar 9, 2021

Please add description if there's dependency that the interface should already have IPv4/IPv6 address configured. Is this dependency supported if Yang model is used for the configuration?

doc/mpls/MPLS_hld.md Outdated Show resolved Hide resolved
@zhangyanzhao
Copy link
Collaborator

Can anyone help to approve and merge this HLD PR? Thanks.

@zhangyanzhao zhangyanzhao merged commit decb477 into sonic-net:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants