[VOQHLD] Update for cli commands #801
Conversation
The CLI section is updated for the design of show commands for system ports and system neighbors
vganesan-nokia
changed the title
|
@ ysmanman - could you please review, thanks. |
| admin@Linecard2:~$ | ||
| ``` | ||
| ### 2.7.1 System ports show command | ||
| The information for the system ports are taken from the **SYSTEM_PORT_TABLE** of **APPL_DB** from a specific namespace |
There was a problem hiding this comment.
Is this show cmd to dump config or status of system port? If it dumps status, should we dump from chassis_app_db?
There was a problem hiding this comment.
This command is to show the config only.
Changes are done to rename the Inband interface pot from **Inband** to **Ethernet-IB**
The lane value changed to "133"
doc/voq/voq_hld.md
Outdated
| Show VOQ system ports information | ||
|
|
||
| Options: | ||
| -d, --display [all] Show internal interfaces [default: all] |
There was a problem hiding this comment.
I think the output of the command show chassis system-ports and show chassis system-ports -d all will be the same. I think we don't need the -d option
There was a problem hiding this comment.
Yes. I'll remove the -d option.
There was a problem hiding this comment.
Fixed. Removed -d option. Also namespace option is made "required" as suggested in the code PR.
doc/voq/voq_hld.md
Outdated
| Show VOQ system neighbors information | ||
|
|
||
| Options: | ||
| -d, --display [all] Show internal interfaces [default: all] |
There was a problem hiding this comment.
I'll remove this.
There was a problem hiding this comment.
Fixed. Removed the "-d" option.
doc/voq/voq_hld.md
Outdated
| Show VOQ system neighbors information | ||
|
|
||
| Options: | ||
| -d, --display [all] Show internal interfaces [default: all] |
There was a problem hiding this comment.
Same as above. Do we need the -d option ?
There was a problem hiding this comment.
No. We do not need this. I'll remove this.
There was a problem hiding this comment.
Fixed. Removed "-d" option.
"-d" option removed for system-ports and system-neighbor commands; Namespace is made required option for system-ports.
…et/SONiC#805 (#3762) What is the motivation for this PR? show chassis-modules command is now being changed to show chassis module please refer to PRs below: sonic-net/SONiC#805 sonic-net/SONiC#801 This PR has dependency on above PRs and can only be merged after they are merged How did you do it? tests/platform_tests/cli/test_show_chassis_module.py change cli command from show chassis-modules to show chassis modules
The CLI section is updated for the design of show commands for system ports and system neighbors