Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blob Polling ScanInfo.LastScan Rounding Issue #2194

Closed
mathewc opened this issue Apr 29, 2019 · 0 comments · Fixed by #2202
Closed

Blob Polling ScanInfo.LastScan Rounding Issue #2194

mathewc opened this issue Apr 29, 2019 · 0 comments · Fixed by #2202

Comments

@mathewc
Copy link
Member

mathewc commented Apr 29, 2019

The code here describes a rounding issue that we have worked around on persistence of the scan info, by subtracting a millisecond. This code seems to indicate that blobs affected by this won't be picked up until the next restart. For a continuous WebJob (or Dedicated Function App) that might be a long time (days/weeks).

Because only the persisted value is decremented, the operating value being used is still susceptible to the issue. E.g. if a blob is added 10ms after the LastSweepCycleLatestModified value has been set, on the next scan it won't be picked up because the check done here is strictly greater than. This blob won't be picked up until after the next host restart.

I think we need to modify the in memory value of LastScan, not just the persisted value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants