[multiasic][voq][bgpconf] Fix for the issue of same BGP router id in all asics #8049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For multiasic, the back end asics use ip addresss of Loopback4096 for BGP router id. In VOQ multi-asic chassis there are no back end asics. All the asics are front end and the iBGP connections are established via Ethernet-IB of asics. Since these asics are not designated as BackEnd, the ip address of interface Loopback0 is used as BGP router id. Since the ip address of Loopback0 is same for all the asics, same router id is used for voq iBGP configurations and hence the iBGP connections are not established. To fix this, we need to use the ip address of Loopback4096 for the front end asics also in multi-asic VOQ systems. Changes are done to implement this fix. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
Changes to use Loopback4096 ip for BGP router id in single asic line cards and multi-asic line cards. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
abdosi
requested changes
Jul 13, 2021
Added unit test for changes done for using Loopback4096 ip address as bgp router-id for voq chassis irrespective of whether the asic is front end or backend Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
Added unit tests. |
abdosi
approved these changes
Jul 26, 2021
|
@arlakshm LGTM. Can you review also ? |
arlakshm
approved these changes
Jul 26, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Aug 4, 2021
…all asics (#8049) For multiasic, the back end asics use ip addresss of Loopback4096 for BGP router id. In VOQ multi-asic chassis there are no back end asics. All the asics are front end and the iBGP connections are established via Ethernet-IB of asics. Since these asics are not designated as BackEnd, the ip address of interface Loopback0 is used as BGP router id. Since the ip address of Loopback0 is same for all the asics in the line card, same router id is used for voq iBGP configurations and hence the iBGP connections are not established. Changes are done to fix this
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…all asics (sonic-net#8049) For multiasic, the back end asics use ip addresss of Loopback4096 for BGP router id. In VOQ multi-asic chassis there are no back end asics. All the asics are front end and the iBGP connections are established via Ethernet-IB of asics. Since these asics are not designated as BackEnd, the ip address of interface Loopback0 is used as BGP router id. Since the ip address of Loopback0 is same for all the asics in the line card, same router id is used for voq iBGP configurations and hence the iBGP connections are not established. Changes are done to fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
For multiasic, the back end asics use ip addresss of Loopback4096 for BGP router id. In VOQ multi-asic chassis there are no back end asics. All the asics are front end and the iBGP connections are established via Ethernet-IB of asics. Since these asics are not designated as BackEnd, the ip address of interface Loopback0 is used as BGP router id. Since the ip address of Loopback0 is same for all the asics in the line card, same router id is used for voq iBGP configurations and hence the iBGP connections are not established. Changes are done to fix this
How I did it
To fix this (i.e., to have different router ids for differen iBGP peers), we need to use the ip address of Loopback4096 for
the front end asics also in VOQ chassis systems. The bgp main configuration template is adjusted to take ip address of Loopback4096 as router id for asics (both in single asic line card and multi-asic line card) in chassis voq systems irrespective of whether the asic is front end or not.
How to verify it