Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config_facts enhancements for multi-asic and support in SonicAsic #2435

Merged
merged 1 commit into from Nov 2, 2020

Conversation

sanmalho-git
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Currently, the config_facts ansible module lacks the following:

  • Support config_db's that have no PORT metadata. This is the case for the global config_db.json on a multi-asic Sonic DUT, or the supervisor card in a chassis.
  • Capability to get "persistent" config facts for a particular namespace - where we have to parse config_db.json file, instead of config_db.json

Also, we need add wrapper method for config_facts to SonicAsic class for being able to use it for multi-asic multi-dut testbeds.

How did you do it?

In config_facts ansible module:

  • To support no PORT metadata, in create_maps method define the port maps as empty dictionary. If 'PORT' is in the config, then only populate these port maps. So, if there is no 'PORT" in the config, return empty dictionaries.

  • To support 'persistent' config_facts across namespace, changed PERSISTENT_CONFIG_PATH to be '/etc/sonic/config_db{}.json". If namespace is passed, we will format PERSISTENT_CONFIG_PATH with asic_id based on the namespace, else we will format this with an empty string.

SonicAsic:

  • Added the wrapper config_facts method to SonicAsic class.

How did you verify/test it?

Tested it against pizza box, multi-asic pizza box, and chassis with multi-asic line cards and supervisor card.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

… anisble module to handle configs with no PORT definition.
@wangxin
Copy link
Collaborator

wangxin commented Nov 2, 2020

retest this please

@wangxin wangxin merged commit ed0d493 into sonic-net:master Nov 2, 2020
@sanmalho-git sanmalho-git deleted the config_facts branch November 2, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants