Converted a few T1 topology testcases for T2 topology to run on multi-dut, and new dut selection mechanism #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
oxygen980
changed the title
oxygen980
changed the title
|
retest vsimage please |
added 4 commits
January 22, 2021 13:16
enum_rand_one_per_hwsku_frontend_hostname fixture will return the same set of random duts per hwsku for a pytest module. Following test cases were modified to run against one random frontend linecard per hwsku in a T2 chassis - test_interfaces.py - test_nbr_health.py - iface_namingmode/test_iface_namingmode.py The changes were: - use enum_dut_frontend_hostname instead of enum_dut_hostname to execute against all frontend linecard - use enum_rand_one_per_hwsku_frontend_hostname instead of rand_one_dut_hostname to execute against one random frontend linecard per hwsku. - Included 't2' topology in topology checks
oxygen980
changed the title
|
retest vsimage please |
1 similar comment
|
retest vsimage please |
yxieca
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Need the capability to run T1 applicable tests against a T2 chassis
How did you do it?
A sonic T2 chassis is a chassis with multiple linecards and a supervisor card. This chassis is represented as a testbed with multiple DUTs (for each linecard and a supervisor card). Thus, we used the multi-dut approach to modify tests to execute against a T2 chassis.
There was also capability to run tests against a single randomly selected DUT from the multi-duts in a testbed using 'rand_one_dut_hostname' fixture. This assumes that all DUTs in the testbed have the same hwsku. However, in a T2 chassis, we could have linecards with different hwsku's. So, we need to run the tests against a single randomly selected DUT per hwsku for a T2 chassis.
We used the 'enum_rand_one_per_hwsku_frontend_hostname' dut selection fixture defined in pytest_generate_tests. For consistency of the random selected DUT list across a module, we made 'enum_rand_one_per_hwsku_frontend_hostname' fixture return the same set of random duts per hwsku for a pytest module.
Following test cases were modified to run against one random frontend linecard per hwsku in a T2 chassis
The changes were:
How did you verify/test it?
Ran modified tests against a T2 chassis with topology defined in ansible/vars/topo-t2.yml.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation