Convert tests test_cpu_memory_usage, test_port_toggle to support T2 c… #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
reviewed
Mar 9, 2021
…hassis and add new test for thermal db on T2 chassis tests/platform_tests/cli/test_show_chassis_module.py - change test select one dut per hwsku instead of running on all DUTs tests/platform_tests/test_cpu_memory_usage.py - change rand_one_dut_hostname to enum_rand_one_per_hwsku_hostname to test per hwsku. tests/platform_tests/test_port_toggle.py - change rand_one_dut_hostname to enum_rand_one_per_hwsku_hostname to test per hwsku. tests/platform_tests/test_thermal_state_db.py - Add new test for t2 chassis to verify thermal data in local state db for all thermal sensors - Verify global state db in supervisor has data for all sensors from all modules in chassis
add get_modular_chassis function to set duthost fact modular_chassis true or false based on api result modified: tests/platform_tests/test_thermal_state_db.py added condition to skip if dut not part of modular chassis
jleveque
approved these changes
Mar 16, 2021
|
@yxieca can you please review |
yxieca
approved these changes
Mar 19, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
sonic-net#3117) Approach What is the motivation for this PR? Add new attribute modular_chassis which will be set true if DUT is modular chassis and False for other Add support to run tests on tests/platform_tests/test_cpu_memory_usage.py, tests/platform_tests/test_port_toggle.py on T2 chassis, change test_show_chassis_module to run duts per hwsku. Add new tests to verify thermal local and global state db on VoQ chassis introduced by PRs sonic-net/sonic-swss-common#395 and sonic-net/sonic-platform-daemons#101 How did you do it? modifications to current tests and new test file as below: tests/common/devices/sonic.py Add new attribute modular_chassis which can be used to skip tests only for modular chassis if DUT is not chassis possible values for attribute are True if DUT is part of modular chassis and False if not part of modular chassis tests/platform_tests/cli/test_show_chassis_module.py change test select one dut per hwsku instead of running on all DUTs tests/platform_tests/test_cpu_memory_usage.py change rand_one_dut_hostname to enum_rand_one_per_hwsku_hostname to test per hwsku. tests/platform_tests/test_port_toggle.py change rand_one_dut_hostname to enum_rand_one_per_hwsku_hostname to test per hwsku. tests/platform_tests/test_thermal_state_db.py Add new test for t2 chassis to verify thermal data in local state db for all thermal sensors Verify global state db in supervisor has data for all sensors from all modules in chassis How did you verify/test it? Validated the modified tests against a chassis .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Add new attribute modular_chassis which will be set true if DUT is modular chassis and False for other
Add support to run tests on tests/platform_tests/test_cpu_memory_usage.py, tests/platform_tests/test_port_toggle.py on T2 chassis, change test_show_chassis_module to run duts per hwsku.
Add new tests to verify thermal local and global state db on VoQ chassis introduced by PRs sonic-net/sonic-swss-common#395 and sonic-net/sonic-platform-daemons#101
How did you do it?
modifications to current tests and new test file as below:
tests/common/devices/sonic.py
Add new attribute modular_chassis which can be used to skip tests only for modular chassis if DUT is not chassis
possible values for attribute are True if DUT is part of modular chassis and False if not part of modular chassis
tests/platform_tests/cli/test_show_chassis_module.py
tests/platform_tests/test_cpu_memory_usage.py
tests/platform_tests/test_port_toggle.py
tests/platform_tests/test_thermal_state_db.py
How did you verify/test it?
Validated the modified tests against a chassis .
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation