Test cases for LAG on Distributed VOQ System #3148
Conversation
|
This pull request introduces 1 alert when merging 35e605b into eb75a74 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 979e34b into b1c4f28 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 0fbdc04 into b1c4f28 - view on LGTM.com new alerts:
|
|
retest vs image please |
|
@yxieca The run is failing in 'test_po_update' duting LogAnalyzer. My code changes are not touching this file. Could you please re-run the build ? |
|
@yxieca, Could you help review these test cases? The failures in the test case are unrelated to this commit. Could you help restart the pipeline? |
|
@yxieca, Could you help restart the pipeline? the failure is not from the code change. |
|
@yxieca @wangxin , @saravanansv - could you please take a look, thanks. |
| if re.search(pattern, lag_member): | ||
| exist = True | ||
| logging.info('lag member {} found in system lag member table {}' | ||
| .format(member, lag_member)) |
There was a problem hiding this comment.
Add break to jump out from the iteration early?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, This is Sambath from Arista. Sorry I am little late on this. The test plan from https://github.com/Azure/sonic-mgmt/pull/3033/files as well as test cases does not seem to have any traffic validation. Would traffic validation be added in a future update to the test plan/test cases? |
|
@skbarista Thank you for the review ! As we have mentioned in the test plan 'This test plan does not cover functioning of LAG as an IP/Layer3 endpoint as that is outside the scope of the code PR' we are not going to have traffic test cases in future too. |
Also, this test case will execute on a T2 topology, of which, LAG is a part. Many T1 test cases, when converted by the chassis subgroup, will cover this forwarding aspect. We kept forwarding out of this because:
|
|
Thanks for the clarification @shubav @oxygen980 |
|
@wangxin comments from you and Arista have been addressed. If it looks fine, could you help get this merged, please? |
What is the motivation for this PR? Test cases for LAG on Distributed VOQ System How did you verify/test it? Verified on T2 topology Supported testbed topology if it's a new test case? T2 topology Co-authored-by: falodiya <renu.falodiy@nokia.com>
What is the motivation for this PR? Test cases for LAG on Distributed VOQ System How did you verify/test it? Verified on T2 topology Supported testbed topology if it's a new test case? T2 topology Co-authored-by: falodiya <renu.falodiy@nokia.com>
Description of PR
Test cases for LAG
Test plan PR :-
#3033
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Test cases for LAG on Distributed VOQ System
How did you do it?
How did you verify/test it?
Verified on T2 topology
Any platform specific information?
Supported testbed topology if it's a new test case?
T2 topology
Documentation