[voq] Test plan and testcase updates for multiasic #3463
Conversation
|
@arlakshm please review this test plan. |
|
@arlakshm - can you please review and approve at the earliest, thanks |
1 similar comment
|
@arlakshm - can you please review and approve at the earliest, thanks |
| @@ -386,6 +387,9 @@ def check_ip_mtu(self): | |||
|
|
|||
| masked_exp_pkt = Mask(exp_pkt) | |||
| masked_exp_pkt.set_do_not_care_scapy(scapy.Ether, "dst") | |||
| if self.ignore_ttl: | |||
There was a problem hiding this comment.
Why we need to ignore_ttl in VoQ chassis ?
There was a problem hiding this comment.
This gets set when we are on VS and the behavior is different than with HW.
|
@tcusto - please address review comments asap, thanks |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@wangxin or @yxieca could you kindly merge this as soon as possible. There's a PR coming up for gen-mg support for multi-asic DUTs, following which we will send another PR with modifications for these voq tests based on the minigraph. Due to these dependencies, request you to kindly get this merged quickly, we're holding a lot of code we would like to upstream. Thanks. |
What is the motivation for this PR? To run the init, neighbor and IP forwarding tests on chassis with multiasic linecards. How did you do it? Scripts in tests/voq were enhanced to handle multiasic cards: All test cases were changed so that ASICs with no neighbors or router interfaces will be skipped. The HIDE_INTERNAL route map is let in place and tests in ipfwd script that are affected by it are removed. CLI and database checks where enhanced to look in the correct namespace on multiasic cards. Other enhancements: Neighbor script cleanup was enhanced be more robust when restoring configuration. PTF port selection was centralized and now uses minigraph. TTL checks were made optional for running ipfwd script on VS testbed. Test plan was updated with these changes. How did you verify/test it? Ran test suite on VoQ chassis. Co-authored-by: Tom Custodio <thomas.custodio@nokia.com>
VoQ test cases updates for multiasic
Summary:
Updates VoQ test plan and test scripts for multiasic line cards.
Type of change
Approach
What is the motivation for this PR?
To run the init, neighbor and IP forwarding tests on chassis with multiasic linecards.
How did you do it?
Scripts in tests/voq were enhanced to handle multiasic cards:
Other enhancements:
How did you verify/test it?
Ran test suite on VoQ chassis.
Any platform specific information?
No
Supported testbed topology if it's a new test case?
T2
Documentation