Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified VOQ portchannel testcases to get asic with portchannels configured. #3754

Merged
merged 2 commits into from Sep 15, 2021

Conversation

oxygen980
Copy link
Contributor

Description of PR

Modified existing voq portchannel testcases to get ASIC with portchannel configured in case of multi-asic.

Summary:
Fixes # (issue)
In case of multi-asic testcase was skipping testcase beacuse it was not able to get ASIC with portchannel configured. Modified testcase to ger ASIC with pc configured else skip test testcase if portchannel not configured.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • [ x] Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

Test case was running only on one ASIC and skipping the testcase if portchannel not configured on that ASIC.

How did you do it?

Check on all ASI to get asic with portchannel configured

How did you verify/test it?

Tested on multi-asic and single asic testbed

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@oxygen980 oxygen980 requested a review from a team as a code owner July 9, 2021 00:34
@shubav
Copy link
Contributor

shubav commented Jul 9, 2021

@arlakshm or @rlhui is it possible to review this, please?

@judyjoseph judyjoseph merged commit 22d09cc into sonic-net:master Sep 15, 2021
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
…igured. (sonic-net#3754)

Modified existing voq portchannel testcases to get ASIC with portchannel configured in case of multi-asic.

Summary:
In case of multi-asic testcase was skipping testcase beacuse it was not able to get ASIC with portchannel configured. Modified testcase to ger ASIC with pc configured else skip test testcase if portchannel not configured.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants