Enhancements platform api tests and change in psustatus_json to use enum_supervisor_dut_hostname #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lguohan - could you please assign this PR for review (PSU related) |
ysmanman
previously approved these changes
Sep 15, 2021
judyjoseph
reviewed
Oct 12, 2021
judyjoseph
reviewed
Oct 12, 2021
harish-kalyanaraman
pushed a commit
to harish-kalyanaraman/sonic-mgmt
that referenced
this pull request
Nov 18, 2021
…num_supervisor_dut_hostname (sonic-net#3756 - rawal01:platform-tests-change) tests/platform_tests/api/test_chassis.py : modify regex for serial number to include '-' tests/platform_tests/api/test_psu.py : enhance test_led to skip test if psu does not support led based on information from platform.json tests/platform_tests/cli/test_show_platform.py : change show_platform_psu_status to use enum_supervisor_dut_hostname instead of rand_one_dut_hostname
…umber to include '-' tests/platform_tests/api/test_psu.py : enhance test_led to skip test if psu does not support led based on information from platform.json tests/platform_tests/cli/test_show_platform.py : change show_platform_psu_status to use enum_supervisor_dut_hostname instead of rand_one_dut_hostname
rawal01
force-pushed
the
platform-tests-change
branch
from
fad49d5
to
efd9417
Compare
|
@judyjoseph @ysmanman We have rebased this PR to the latest github and addressed the review comments. Could you please re-review. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
judyjoseph
approved these changes
Feb 10, 2022
mannytaheri
pushed a commit
to mannytaheri/sonic-mgmt
that referenced
this pull request
Mar 2, 2022
…num_supervisor_dut_hostname (sonic-net#3756) * tests/platform_tests/api/test_chassis.py : modify regex for serial number to include '-' tests/platform_tests/api/test_psu.py : enhance test_led to skip test if psu does not support led based on information from platform.json tests/platform_tests/cli/test_show_platform.py : change show_platform_psu_status to use enum_supervisor_dut_hostname instead of rand_one_dut_hostname * Addressing review comments
mannytaheri
pushed a commit
to mannytaheri/sonic-mgmt
that referenced
this pull request
Mar 9, 2022
…num_supervisor_dut_hostname (sonic-net#3756 - rawal01:platform-tests-change) tests/platform_tests/api/test_chassis.py : modify regex for serial number to include '-' tests/platform_tests/api/test_psu.py : enhance test_led to skip test if psu does not support led based on information from platform.json tests/platform_tests/cli/test_show_platform.py : change show_platform_psu_status to use enum_supervisor_dut_hostname instead of rand_one_dut_hostname - Review comments and rebase of PR#3756 (sonic-net#3756 - rawal01:platform-tests-change) - Allow dashes in the serial number in the syseeprom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
change in test_chassis to include '-' in regex for serial number as in case of some Nokia platform.
Include a method to skip led test for psu which do no support and test master led to include only supported colors based on
platform.json.
In test_show_platform.py fix psu test to use enum_supervisor_dut_hostname to be consistant with other tests
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Enhancement to skip test_led for psu if not supported by platform, change to use consistent dut enumerator in test_platform_psustatus_json test
How did you do it?
tests/platform_tests/api/test_chassis.py : modify regex for serial number to include '-'
tests/platform_tests/api/test_psu.py : enhance test_led to skip test if psu does not support led based on information from platform.json
tests/platform_tests/cli/test_show_platform.py : change show_platform_psu_status to use enum_supervisor_dut_hostname instead of rand_one_dut_hostname
How did you verify/test it?
Tested on voq chassis and pizza box
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation