Modified iface_namingmode testcases to get internal ports on voq system #3757
Conversation
| @@ -37,7 +37,7 @@ def setup(duthosts, enum_rand_one_per_hwsku_frontend_hostname, tbinfo): | |||
|
|
|||
| hwsku = duthost.facts['hwsku'] | |||
| minigraph_facts = duthost.get_extended_minigraph_facts(tbinfo) | |||
| port_alias_facts = duthost.port_alias(hwsku=hwsku, include_internal=False)['ansible_facts'] | |||
| port_alias_facts = duthost.port_alias(hwsku=hwsku, include_internal=True)['ansible_facts'] | |||
There was a problem hiding this comment.
What internal ports will be included? Inband ports? Also the change is not only for voq system, right?
There was a problem hiding this comment.
@ysmanman Yes this is for inband ports and the changes will take care of all type of DUT.
There was a problem hiding this comment.
why do we need this change ? The port alias is not needed for inband ports I think we can ignore them.
The port alias is mainly needed for front panel ports.
| pfc_rx = dutHostGuest.shell('SONIC_CLI_IFACE_MODE={} sudo show pfc counters | sed -n "/Port Rx/,/^$/p"'.format(ifmode))['stdout'] | ||
| pfc_tx = dutHostGuest.shell('SONIC_CLI_IFACE_MODE={} sudo show pfc counters | sed -n "/Port Tx/,/^$/p"'.format(ifmode))['stdout'] | ||
| pfc_rx = dutHostGuest.shell('SONIC_CLI_IFACE_MODE={} sudo show pfc counters -d all | sed -n "/Port Rx/,/^$/p"'.format(ifmode))['stdout'] | ||
| pfc_tx = dutHostGuest.shell('SONIC_CLI_IFACE_MODE={} sudo show pfc counters -d all | sed -n "/Port Tx/,/^$/p"'.format(ifmode))['stdout'] |
There was a problem hiding this comment.
Is this -d all option supported on release earlier than 202012?
There was a problem hiding this comment.
'-d' option came in with multi-asic support. If 202012 supports multi-asic, then it should have the '-d' option
There was a problem hiding this comment.
why do we need this change ?
| @@ -37,7 +37,7 @@ def setup(duthosts, enum_rand_one_per_hwsku_frontend_hostname, tbinfo): | |||
|
|
|||
| hwsku = duthost.facts['hwsku'] | |||
| minigraph_facts = duthost.get_extended_minigraph_facts(tbinfo) | |||
| port_alias_facts = duthost.port_alias(hwsku=hwsku, include_internal=False)['ansible_facts'] | |||
| port_alias_facts = duthost.port_alias(hwsku=hwsku, include_internal=True)['ansible_facts'] | |||
There was a problem hiding this comment.
why do we need this change ? The port alias is not needed for inband ports I think we can ignore them.
The port alias is mainly needed for front panel ports.
| pfc_rx = dutHostGuest.shell('SONIC_CLI_IFACE_MODE={} sudo show pfc counters | sed -n "/Port Rx/,/^$/p"'.format(ifmode))['stdout'] | ||
| pfc_tx = dutHostGuest.shell('SONIC_CLI_IFACE_MODE={} sudo show pfc counters | sed -n "/Port Tx/,/^$/p"'.format(ifmode))['stdout'] | ||
| pfc_rx = dutHostGuest.shell('SONIC_CLI_IFACE_MODE={} sudo show pfc counters -d all | sed -n "/Port Rx/,/^$/p"'.format(ifmode))['stdout'] | ||
| pfc_tx = dutHostGuest.shell('SONIC_CLI_IFACE_MODE={} sudo show pfc counters -d all | sed -n "/Port Tx/,/^$/p"'.format(ifmode))['stdout'] |
There was a problem hiding this comment.
why do we need this change ?
…3757 - oxygen980:internal_interface)
Description of PR
Modified iface_namingmode testcases to get internal interfaces.
Summary:
Fixes # (issue)
The script was missing internal interfaces and some testcases were failing.
Type of change
Back port request
Approach
What is the motivation for this PR?
Testcases were missing check on internal interfaces
How did you do it?
Modified testcases to get internal ports.
How did you verify/test it?
verified on VOQ system.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation