Modified iface_namingmode testcases to get spine ports for T2 topology #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaheshm
reviewed
Sep 14, 2021
| @@ -869,7 +869,7 @@ def spine_ports(self, setup): | |||
| spine_ports['alias'] = list() | |||
|
|
|||
| for key, value in minigraph_neighbors.items(): | |||
| if (key in setup['physical_interfaces']) and ('T2' in value['name']): | |||
| if key in setup['physical_interfaces'] and ('T2' in value['name'] or (tbinfo['topo']['type'] == 't2' and 'T3' in value['name'])): | |||
There was a problem hiding this comment.
can you split the statement, prefer 80 chars, but 120 is fine.
There was a problem hiding this comment.
@rlhui yes this was done a long back.
ysmanman
previously approved these changes
Sep 15, 2021
oxygen980
force-pushed
the
spine_ports
branch
from
dd15b3c
to
d174114
Compare
harish-kalyanaraman
pushed a commit
to harish-kalyanaraman/sonic-mgmt
that referenced
this pull request
Nov 18, 2021
…sonic-net#3758 - oxygen980:spine_ports)
smaheshm
approved these changes
Feb 10, 2022
mannytaheri
pushed a commit
to mannytaheri/sonic-mgmt
that referenced
this pull request
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Modified iface_namingmode testcases to get spine ports for T2 topology
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Spine ports function was not able to get spine ports for T2 topology, added condition for the same.
How did you do it?
Added condition to get spine [ports for T2 topolgy.
How did you verify/test it?
Tested on VOQ system.
Any platform specific information?
Supported testbed topology if it's a new test case?
T2
Documentation