Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes test_nbr_health test #3763

Closed
wants to merge 1 commit into from
Closed

Conversation

rawal01
Copy link
Contributor

@rawal01 rawal01 commented Jul 9, 2021

Summary:
In neighbor health test add ASIC to be ignored for neighbor metadata which is included in multi asic line cards.

Type of change

  • Bug fix
  • [x ] Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

With introduced support for generating minigraph for multi asic line cards by PR #3746 which will include asics information in neighbor metadata so changing test to skip check for asic neighbor health as they are part of same DUT.

How did you do it?

tests/test_nbr_health.py add ASIC as key to be ignored for neighbor metadata for multi asic line cards

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

tests/test_nbr_health.py add ASIC as key to be ignored for neighbor metadata for multi asic line cards
@rawal01 rawal01 requested a review from a team as a code owner July 9, 2021 12:48
@anshuv-mfst anshuv-mfst requested a review from a team August 3, 2021 23:10
@arlakshm
Copy link
Contributor

arlakshm commented Aug 3, 2021

This problem is fixed in this PR #3908
Can you check with the sonic-mgmt

@rawal01 rawal01 closed this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants