[rsyslog] Fixing pretest and posttest checks for multiasic boards #3764
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdosi
reviewed
Jul 21, 2021
tests/test_pretest.py
Outdated
| continue | ||
| cmds = [] | ||
| cmds.append(cmd_disable_rate_limit.format(feature_name)) | ||
| cmds.append(cmd_reload.format(feature_name)) | ||
| cmds.append(cmd_disable_rate_limit.format(docker_name)) |
There was a problem hiding this comment.
This will be fixed by sonic-net/sonic-buildimage#8390, will update for when that is merged.
tcusto
force-pushed
the
chassis_pretest
branch
from
e3e898e
to
81f6365
Compare
|
Rebased to latest and adapted to new test_pretest.py, changed test_posttest.py to follow same approach. |
smaheshm
approved these changes
Sep 14, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Nov 5, 2021
harish-kalyanaraman
pushed a commit
to harish-kalyanaraman/sonic-mgmt
that referenced
this pull request
Nov 18, 2021
…nic-net#3764 - tcusto:chassis_pretest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixing pretest and posttest check rsyslog_rate_limit for multiasic boards
Type of change
Back port request
Approach
What is the motivation for this PR?
When disabling/enabling rsyslog rate limit, we are using 'show feature status'. The output of this command is being used for 'docker exec -i ....' to disable/enable rsyslog rate limit. For masic, the show feature status doesn't show the namespace features (like bgp0, bgp1, etc.), but only 'bgp'. Thus, when we go and do 'docker exec -i bgp' it fails.
How did you do it?
Fix is to use output of 'docker ps' instead of 'show feature status'
How did you verify/test it?
Verified on VoQ system.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation