Changing ipv6 loopback addresses on the linecards to be on different subnets and adding t2 as a supported topology in veos #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subnets and adding t2 as a supported topology in veos In bgpd.main.conf.j2 in sonic-buildimage (http://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-fpm-frr/frr/bgpd/bgpd.main.conf.j2#L77), Ipv6 Loopback0 addresses are using a 64 bit mask. In t2 topology, we have 2 linecards, and we were assigning two different IPv6 addresses: - fc00:10::1/128 - fc00:10::2/128 However, in bgpd.main.conf.j2 in sonic-buildimage (http://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-fpm-frr/frr/bgpd/bgpd.main.conf.j2#L77), ipv6 Loopback0 addresses are using a 64 bit mask. Thus, the route to the Loopback0 address of the remote linecard was being masked by the local Loopback0 address, and not pointing to the inband port. Fix for this is to use different subnets for each linecard. So, changing the Loopback0 addresses to: - fc00:10::1/128 - fc00:11::1/128 Also, t2 topology was missing from veos as a supported topology
abdosi
approved these changes
Jul 21, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…subnets and adding t2 as a supported topology in veos (sonic-net#3797) In bgpd.main.conf.j2 in sonic-buildimage (http://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-fpm-frr/frr/bgpd/bgpd.main.conf.j2#L77), Ipv6 Loopback0 addresses are using a 64 bit mask. In t2 topology, we have 2 linecards, and we were assigning two different IPv6 addresses: - fc00:10::1/128 - fc00:10::2/128 However, in bgpd.main.conf.j2 in sonic-buildimage (http://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-fpm-frr/frr/bgpd/bgpd.main.conf.j2#L77), ipv6 Loopback0 addresses are using a 64 bit mask. Thus, the route to the Loopback0 address of the remote linecard was being masked by the local Loopback0 address, and not pointing to the inband port. Fix for this is to use different subnets for each linecard. So, changing the Loopback0 addresses to: - fc00:10::1/128 - fc00:11::1/128 Also, t2 topology was missing from veos as a supported topology
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In t2 topology, we have 2 linecards, and we were assigning two different IPv6 addresses:
However, in bgpd.main.conf.j2 in sonic-buildimage (http://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-fpm-frr/frr/bgpd/bgpd.main.conf.j2#L77), ipv6 Loopback0 addresses are using a 64 bit mask. Thus, the route to the Loopback0 address of the remote linecard was being masked by the local Loopback0 address and not pointing to the inband port.
How did you do it?
Fix for this is to use different subnets for each linecard. So, changing the Loopback0 addresses to:
Also, t2 topology was missing from veos as a supported topology
How did you verify/test it?
Ran voq suites in tests/voq directory with the changes above.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation