Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SRV6] Sonic-swss changes for SRV6 #1964

Merged
merged 38 commits into from Nov 11, 2021
Merged

[SRV6] Sonic-swss changes for SRV6 #1964

merged 38 commits into from Nov 11, 2021

Conversation

kperumalbfn
Copy link

@kperumalbfn kperumalbfn commented Oct 15, 2021 •
edited

SONiC swss support for SRV6

  • RouteOrch changes to trigger SRV6 nexthops and update route entries
  • SRV6Orch changes to create SRV6 nexthops, tunnel and SRV6 MY_SID_ENTRY objects
  • CRMOrch changes to include SRV6 MY_SID

sonic-swss-common changes for SRV6 APPL_DB tables: sonic-net/sonic-swss-common#538
sonic-utiliities changes for SRV6 CRM: sonic-net/sonic-utilities#1883
sonic-buildimage changes for SRV6 CRM: sonic-net/sonic-buildimage#9004

SRV6 HLD: sonic-net/SONiC#795

@kperumalbfn
Copy link
Author

sonic-swss srv6 test scripts will be pushed soon.

@zhangyanzhao
Copy link
Collaborator

@caizhenghui-juniper would you please help to review?

@hzheng5 hzheng5 mentioned this pull request Oct 21, 2021
Merged
prsunny
prsunny reviewed Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add VS tests

@prsunny
Copy link
Collaborator

prsunny commented Oct 26, 2021

@venkatmahalingam , please review

kperumalbfn
kperumalbfn commented Oct 26, 2021
View reviewed changes
orchagent/neighorch.cpp Show resolved Hide resolved
orchagent/srv6orch.cpp Outdated Show resolved Hide resolved
orchagent/srv6orch.cpp Show resolved Hide resolved
@kperumalbfn
Copy link
Author

@caizhenghui-juniper Please review this PR and approve it.

@kperumalbfn
Copy link
Author

/AzurePipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 1964 in repo Azure/sonic-swss

@kperumalbfn
Copy link
Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

prsunny
prsunny reviewed Nov 9, 2021
View reviewed changes
orchagent/orchdaemon.cpp Outdated Show resolved Hide resolved
orchagent/crmorch.cpp Outdated Show resolved Hide resolved
orchagent/routeorch.cpp Outdated Show resolved Hide resolved
orchagent/routeorch.cpp Show resolved Hide resolved
orchagent/routeorch.cpp Outdated Show resolved Hide resolved
orchagent/routeorch.cpp Outdated Show resolved Hide resolved
orchagent/srv6orch.cpp Outdated Show resolved Hide resolved
orchagent/srv6orch.cpp Show resolved Hide resolved
venkatmahalingam
venkatmahalingam reviewed Nov 10, 2021
View reviewed changes
orchagent/routeorch.cpp Show resolved Hide resolved
orchagent/routeorch.cpp Show resolved Hide resolved
@prsunny
Copy link
Collaborator

prsunny commented Nov 11, 2021

@venkatmahalingam , @caizhenghui-juniper , please review/sign-off.

@kperumalbfn
Copy link
Author

Thanks @prsunny @venkatmahalingam

@prsunny @caizhenghui-juniper's approval got cleared after code changes.

@kperumalbfn
Copy link
Author

@prsunny Please merge

@reshmaintel
Copy link

@prsunny @venkatmahalingam @caizhenghui-juniper @zhangyanzhao
Thank you for your review help so far. Could you please help with the last step review/merge for this PR as well.

@prsunny prsunny merged commit 37c197d into sonic-net:master Nov 11, 2021
@kperumalbfn kperumalbfn deleted the swss_srv6 branch November 11, 2021 21:06
@stephenxs stephenxs mentioned this pull request Nov 17, 2021
Merged
5 tasks
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@arlakshm
preserve old order for config reload (sonic-net#1964)
96143ee 
What I did
Fixes sonic-net/sonic-buildimage#9473

How I did it
Preserve the old order of the config reload

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
This was referenced Nov 9, 2022
Closed
Open
Open
liuyuefengcn pushed a commit to liuyuefengcn/sonic-swss that referenced this pull request Jan 15, 2024
@liuyuefengcn
[SRV6] Sonic-swss changes for SRV6 (sonic-net#1964)
aa0206c 
*RouteOrch changes to trigger SRV6 nexthops and update route entries
*SRV6Orch changes to create SRV6 nexthops, tunnel and SRV6 MY_SID_ENTRY objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

@venkatmahalingam venkatmahalingam venkatmahalingam approved these changes

@caizhenghui-juniper caizhenghui-juniper caizhenghui-juniper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kperumalbfn @zhangyanzhao @prsunny @mssonicbld @reshmaintel @venkatmahalingam @caizhenghui-juniper @hzheng5