Routed subinterface enhancements #529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for long name and short name routed subinterfaces This swss common library provides APIS for: - Performs Subinterface validation checks - Get parent interface corresponding to subinterface(short/long name) - Get subinterface index
kcudnik
reviewed
Sep 15, 2021
kcudnik
reviewed
Sep 15, 2021
kcudnik
reviewed
Sep 15, 2021
kcudnik
reviewed
Sep 15, 2021
kcudnik
reviewed
Sep 15, 2021
kcudnik
approved these changes
Sep 16, 2021
|
@prsunny , why is this pr on swss-common? are you sponsoring this pr? |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Oct 1, 2021
zhangyanzhao
moved this from In progress
to Reviewer approved
in swss common PR tracking
|
Recommend moving to sonic-swss/lib |
|
Closing this pull request since this code is moved to swss/lib which can be found as part of swss PR 2017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Routed subinterfae enhancements HLD #833
Add support for long name and short name routed subinterfaces.
Add support for long name and short name routed subinterfaces.
This swss common library provides APIS for:
Why I did it
Routed subinterface feature was broken for physical and portchannel subinterfaces for subinterface name exceeding 15 characters due to kernel limitation of netdev name length of 15.
How I verified it
Routed subinterface Unit tests