[voq/inbandif] Voq inbandif port #1363
Conversation
| @@ -322,7 +322,7 @@ class SFPShow(object): | |||
| sorted_table_keys = natsorted(port_table_keys) | |||
| for i in sorted_table_keys: | |||
| interface = re.split(':', i, maxsplit=1)[-1].strip() | |||
| if interface and interface.startswith(front_panel_prefix()) and not interface.startswith(backplane_prefix()): | |||
| if interface and interface.startswith(front_panel_prefix()) and not interface.startswith(backplane_prefix()) and not interface.startswith(inband_prefix()): | |||
There was a problem hiding this comment.
I think right now, there is no need to check not interface.startswith(backplane_prefix()) and not interface.startswith(inband_prefix()) since front_panel_prefix is different from the other prefixes. But it's safer in case in future the prefixes are changed. So approved.
There was a problem hiding this comment.
Thanks for approving. We changed the prefix. As per the review comments during Recycle port HLD, we changed the Inband port prefix to "Ethernet-IB". With this, it is required to handle inband_prefix similar to backplane_prefix.
vganesan-nokia
force-pushed
the
voq-inbandif-port
branch
2 times, most recently
from
3a67f99
to
abead69
Compare
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@ngoc-do - please re-approve |
|
can we add unit test case to check port is skip. |
Yes. I'll add test case to check skipping Ethernet-IB. |
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Inband port is avaialable in PORT table. But regular port handlings are not applicable for Inband port. Changes in this PR are to avoid regular port handling on Inband port.
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Changes to skip reporting error for host routes of voq neighbors programmed on the inband interface. These routes will be in APPL DB but will not be available in ASIC DB. We do not require them in ASIC DB since host routes for the voq neighbors are created in SAI as part of neighbor programming itself.
|
Capturing approvals before rebasing
|
vganesan-nokia
force-pushed
the
voq-inbandif-port
branch
from
e54c3af
to
16dbe1e
Compare
- Unit test case added to cover code changes in route check untility to avoid reporting error for missing routes in asic db for routes of voq neighbors on inband interface - Mock appl db is updated to include inband interface so that sfpshow code changes for skipping inband interface will be unit tested Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
Fixed. Added test case for route check to unit test changes done in route_check.py. Updated the mock appl db to include inband interface so that the code changes in sfpshow will be unit tested (the verification of skipping inband port). |
|
@abdosi, should this get into 202012 ? |
Inband port can be made available in PORT table. But regular port handlngs are not applicable for Inband port. This PR has change to avoid regular port handling for inband port for route_check and sfpshow script.
- What I did
Inband port can be made available in PORT table. But regular port handlngs are
not applicable for Inband port. This PR has change to avoid regular port handling for inband port
Ref: VOQ HLD https://github.com/Azure/SONiC/blob/master/doc/voq/voq_hld.md
- How I did it
The inband port is considered similar to back plane port. An inband_prefix = "Ethernet-IB" and this is checked in all places to avoid regular port handling.
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
Note: This PR depends on sonic-buildimage PR sonic-net/sonic-buildimage#6477