[multi-asic][cli][chassis-db] Avoid connecting to chassis db for cli commands executed from linecard #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 5, 2021
|
Hi @mlorrillere - could you please review, thanks. |
mlorrillere
previously approved these changes
Jul 12, 2021
judyjoseph
reviewed
Aug 31, 2021
| db_list = list(self.db.get_db_list()) | ||
| if not device_info.is_supervisor(): | ||
| try: | ||
| db_list.remove('CHASSIS_APP_DB') |
There was a problem hiding this comment.
Similar comment, we can have a function in py_common/multi_asic.py or py_common/deviceinfo to get the list of chassis db instances and use here. Will help in future when we add more DBs
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@judyjoseph, would you please re-start the azure pipeline again? The build is still not picking up the dependednt changes from sonic-net/sonic-buildimage#8065. Thanks |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
October 4, 2021 10:05
Currently, for all the cli commands, we connect to all databases mentioned in the database_config.json. The database_config.json also includes the databases from chassis redis server from supervisor card. It is unneccessary to connect to databases from chassis redis server when cli commands are executed form linecard. But we need to allow connection to chassis databases when the cli commands are executed from supervisor card. The changes in this PR fixes this problem. The constructor of Db() class which is instantiated for every CLI command execution is changed to skip chassis databases from the list of collected databases if the card is not supervisor card. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
is_voq_supervisor() renamed to is_supervisor() as this API is applicable for non VOQ chassis also. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
vganesan-nokia
force-pushed
the
cli_chassis_db-1
branch
from
ae597de
to
519e4bf
Compare
judyjoseph
approved these changes
Oct 12, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Oct 14, 2021
…commands executed from linecard (#1707) * [multi-asic][cli][chassis-db] Avoid connecting to chassis db Currently, for all the cli commands, we connect to all databases mentioned in the database_config.json. The database_config.json also includes the databases from chassis redis server from supervisor card. It is unneccessary to connect to databases from chassis redis server when cli commands are executed form linecard. But we need to allow connection to chassis databases when the cli commands are executed from supervisor card. The changes in this PR fixes this problem. The constructor of Db() class which is instantiated for every CLI command execution is changed to skip chassis databases from the list of collected databases if the card is not supervisor card. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Currently, for all the cli commands, we connect to all databases mentioned in the database_config.json. The database_config.json also includes the databases from chassis redis server from supervisor card. It is unneccessary to connect to databases from chassis redis server when cli commands are executed form linecard. But we need to allow connection to chassis databases when the cli commands are executed from supervisor card. This problem is fixed by this PR
How I did it
The constructor of Db() class which is instantiated for every CLI command execution is changed to skip chassis databases from the list of collected databases if the card is not supervisor card. This PR is dependent on sonic-buildimage PR sonic-net/sonic-buildimage#8065.
How to verify it
In voq chassis execute some CLI commands (show, config, etc.) and make sure that commands are executed without any CLI errors no matter whether there is supervisor card or not.
Previous command output (if the output of a command-line utility has changed)
No command syntax or outputs changed
New command output (if the output of a command-line utility has changed)
N/A