Add ACR metrics to supported metrics overview #27991
Conversation
|
@tomkerkhove : Thanks for your contribution! The author, @anirudhcavale, has been notified to review your proposed change. |
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
|
@tomkerkhove : Thanks for your contribution! The author, @anirudhcavale, has been notified to review your proposed change. |
|
Can you add OS type as RunDuration's dimension? |
|
I can, what is the value for it? Or is For what it's worth when I check in the Azure portal it's not there: |
|
The dimension name should be BuildOsType. Storage has Metrics SuccessE2ELatency with dimensions “GeoType”, “ApiName” and “Authentication”. But those dimensions are not available in portal. So I guess we need to be consistent with storage here. |
|
@tomkerkhove : Thanks for your contribution! The author, @anirudhcavale, has been notified to review your proposed change. |
|
Perfect, docs adapted - Thanks for letting me know @msyihchen |
|
@tomkerkhove Thanks for updating and contributing! |
|
@yihuang<mailto:Yihuang.Chen@microsoft.com> SuccessE2E latency from Storage does have those dimensions and they appear in the portal. I think Tom was saying the OSBuild Type is not showing in the portal for ACR.
[cid:image002.jpg@01D4E4AC.F33C4C30]
From: Yihuang Chen <notifications@github.com>
Sent: Wednesday, March 27, 2019 12:03 PM
To: MicrosoftDocs/azure-docs <azure-docs@noreply.github.com>
Cc: Anirudh Cavale <ancav@microsoft.com>; Mention <mention@noreply.github.com>
Subject: Re: [MicrosoftDocs/azure-docs] Add ACR metrics to supported metrics overview (#27991)
The dimension name should be BuildOsType. Storage has Metrics SuccessE2ELatency with dimensions “GeoType”, “ApiName” and “Authentication”. But those dimensions are not available in portal. So I guess we need to be consistent with storage here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F27991%23issuecomment-477305585&data=02%7C01%7Cancav%40microsoft.com%7C2a85080d2f0d4b16756208d6b2e6cc32%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636893101674618623&sdata=lxsggMimtHLxSWM4ZFTfXtnx3J06K3JQcgQ8F9zRnEE%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZYAIuNMDWOSkOq9JcIdrI_K0rtk72Ceks5va8BVgaJpZM4cKg7D&data=02%7C01%7Cancav%40microsoft.com%7C2a85080d2f0d4b16756208d6b2e6cc32%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636893101674618623&sdata=pTwnFZqm6gpwgDDRMY5SiUBOmWnCfyQCYx0R5%2Br6PdY%3D&reserved=0>.
|
|
Oh I see. We need to select a metric first and then add a filter. Dimension is part of filter. @tomkerkhove Sorry I told you the wrong thing. Storage does have those dimensions in portal but we don't. Can you revert the last commit? |
|
@tomkerkhove : Thanks for your contribution! The author, @anirudhcavale, has been notified to review your proposed change. |
|
Ping @anirudhcavale |
|
#please-close the ACR metrics have been added. |
ghost
mentioned this pull request
Add ACR metrics to supported metrics overview