Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addFileAttachmentAsync Appends Invalid Authorization Header #322

Closed
kkerr1 opened this issue Dec 5, 2018 · 15 comments
Closed

addFileAttachmentAsync Appends Invalid Authorization Header #322

kkerr1 opened this issue Dec 5, 2018 · 15 comments
Assignees
Labels
Area: Outlook Issue related to Outlook add-ins Resolution: external Issue isn't related to the Office Add-ins platform, Office JavaScript APIs, or documentation Resolution: has workaround Problem can be avoided by implementing workaround

Comments

@kkerr1
Copy link

kkerr1 commented Dec 5, 2018

Expected Behavior

Office.context.mailbox.item.addFileAttachmentAsync successfully attaches externally hosted files, for example those located on AWS S3.

Current Behavior

Office.context.mailbox.item.addFileAttachmentAsync has started appending an invalid header which S3 rightfully rejects. The header is Authorization: Bearer. I have not indicated that this call should be authenticating, also this is an invalid call as there is of course no token provided.

Context

We use S3 to facilitate the uploading of attachment files via the Outlook Add-in. This issue is likely to cause issues for other cloud providers or servers as an invalid header is included. We have an in-production application that is broken in the most recent version of Outlook due to this issue. It works properly in older versions.

https://stackoverflow.com/questions/53586742/addfileattachmentasync-appends-invalid-authorization-header

Your Environment

  • Platform [PC desktop, Mac, iOS, Office Online]: PC Desktop
  • Host [Excel, Word, PowerPoint, etc.]: Outlook
  • Office version number: Version 1811 (Build 11029.20079 Click-to-Run)
  • Operating System: Windows 10
@JuaneloJuanelo JuaneloJuanelo added the Area: Outlook Issue related to Outlook add-ins label Dec 5, 2018
@kbrandl
Copy link
Contributor

kbrandl commented Dec 5, 2018

@kkerr1 thanks for reaching out about this and sorry to hear that you're having this problem.

@exextoc are you able to provide input on this issue?

@exextoc
Copy link
Collaborator

exextoc commented Dec 6, 2018

We are aware of this issue. We responded to the StackOverflow post. We have engaged the Outlook team to address this information. We don't have an ETA for fixing this issue. The workaround is to host the files elsewhere.

@dmahugh dmahugh added the Status: fix pending Fix is complete but awaiting prod deployment label Jan 22, 2019
@adam-harwood
Copy link

Is there an update on this issue? It's 7 months on, and I can still replicate the issue. The answer of "use a service that has more relaxed security" isn't a great workaround to have in place for this long, especially when it can involve customer data.

@kkerr1
Copy link
Author

kkerr1 commented Aug 6, 2019

We are now seeing this in the latest semi-annual releases 1902 and 1907 monthly releases. This means that seven months after reporting this issue, it has expanded to both public release channels. Without a fix we will have to build a workaround to address. @exextoc and @kbrandl This is extremely disappointing and the second time a bug has required a substantial workaround on our end in the last few months. The other being #433. Is there a better mechanism to escalate these issues?

@kbrandl
Copy link
Contributor

kbrandl commented Aug 6, 2019

@kkerr1 thanks for reaching out about this, and sorry to see that the team's progress has been so slow with this issue -- I can certainly understand your frustration.

@wamaina FYI (for escalation, since you're currently on rotation.) @exextoc can you please provide an status update on this issue (including an ETA for resolution, if available)?

@adam-harwood
Copy link

Can we get a status update on the status update?

@kbrandl kbrandl added the Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs label Sep 2, 2019
@adam-harwood
Copy link

@exextoc any update on this issue? It's coming up to a year since opening, and almost 4 months since a status update was asked for.

@JuaneloJuanelo
Copy link

Sorry for the enormous delay on this, this is unfortunately not something that our team directly owns, so that's why, mostly, the delay.
We recently ship an attachments API (in our 1.8 release) that enables you to add a base64 encoded attachment, have you tried this? here is more info https://docs.microsoft.com/en-us/office/dev/add-ins/reference/objectmodel/requirement-set-1.8/office.context.mailbox.item#addfileattachmentfrombase64asyncbase64file-attachmentname-options-callback

the fix for the original bug is still pending and might be delayed a bit more. no specific ETA.
thanks for your patience.

@JuaneloJuanelo JuaneloJuanelo added Resolution: has workaround Problem can be avoided by implementing workaround Needs: author feedback Waiting for author (creator) of Issue to provide more info labels Nov 19, 2019
@adam-harwood
Copy link

adam-harwood commented Nov 19, 2019

Thank you @JuaneloJuanelo . We have tried that API, and it does fix the issue, but as far as I know 1.8 is still in preview and not GA. Do you have an expected timeline for GA?

@JuaneloJuanelo
Copy link

1.8 is GA now! it was announced a couple of weeks ago (@ignite!!)
Starting on: Windows: 16.0.12130.20272 , Mac: 16.31 November Update, Online November

@adam-harwood
Copy link

Oh great, thank you @JuaneloJuanelo . That workaround is sufficient for us then.

@ghost ghost added the Status: no recent activity Issue or PR is stale (no recent activity) label Nov 23, 2019
@ghost
Copy link

ghost commented Nov 23, 2019

This issue has been automatically marked as stale because it is marked as needing author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your interest in Office Add-ins!

@adam-harwood
Copy link

This issue definitely cannot be closed. Although a workaround is present, the original issue still exists, and as far as I know not even the documentation has been changed to indicate the old API doesn't work.

@ghost ghost removed the Status: no recent activity Issue or PR is stale (no recent activity) label Nov 24, 2019
@kbrandl kbrandl removed the Needs: author feedback Waiting for author (creator) of Issue to provide more info label Nov 24, 2019
@JuaneloJuanelo JuaneloJuanelo added Resolution: external Issue isn't related to the Office Add-ins platform, Office JavaScript APIs, or documentation and removed Status: fix pending Fix is complete but awaiting prod deployment Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs labels Nov 26, 2019
@JuaneloJuanelo
Copy link

JuaneloJuanelo commented Nov 26, 2019

As pointed out in stackOverflow, but adding this info here just as reference, this is an Outlook bug, exactly the same situation happens when using Outlook manually. This is not in the Office Platform.
As soon as the bug gets fixed in Outlook, the API will work as usual, as a workaround please use the attachments API.

Given that

a. this is not an issue on the Office Platform team and
b. Outlook team is aware and working on a fix (internally tracked with 2599582) and
c. there is a workaround using the new attachments API.

I am closing this issue.

@exextoc
Copy link
Collaborator

exextoc commented Sep 3, 2021

We have fixed the bug and the fix should be available in build 16.0.12625.10000 or later. Depending on the release channel you are on, getting an updated build can take anywhere from 4-8 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Outlook Issue related to Outlook add-ins Resolution: external Issue isn't related to the Office Add-ins platform, Office JavaScript APIs, or documentation Resolution: has workaround Problem can be avoided by implementing workaround
Projects
None yet
Development

No branches or pull requests

6 participants