Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added MinGW docker image #8

Merged
merged 1 commit into from Feb 19, 2022
Merged

Added MinGW docker image #8

merged 1 commit into from Feb 19, 2022

Conversation

melihmutlu
Copy link
Collaborator

@melihmutlu melihmutlu commented Jan 26, 2022 •
edited

  • Adds dockerfile for MinGW that uses windows_ci_base as base image.
  • Includes powershell script that installs stuff needed for MinGW
  • Adds test task for MinGW into CI

@melihmutlu melihmutlu changed the title WIP: Adding MinGW docker image Added MinGW docker image Jan 26, 2022
@melihmutlu melihmutlu marked this pull request as ready for review January 26, 2022 12:27
anarazel
anarazel reviewed Jan 28, 2022
View reviewed changes
Copy link
Owner

@anarazel anarazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link to a cirrus task doing an example build with this container spec? I couldn't find one immediately...

scripts/windows_install_mingw64.ps1 Outdated Show resolved Hide resolved
scripts/windows_install_mingw64.ps1 Outdated Show resolved Hide resolved
scripts/windows_install_mingw64.ps1 Outdated Show resolved Hide resolved
scripts/windows_install_mingw64.ps1 Outdated Show resolved Hide resolved
@anarazel
Copy link
Owner

Failed to build: https://cirrus-ci.com/task/5965862266994688?logs=build#L259:

[00:18:39.427] starting mingw64 installation
[00:19:23.961] Invoke-WebRequest : Unable to read data from the transport connection: An 
[00:19:23.961] existing connection was forcibly closed by the remote host.
[00:19:23.962] At C:\scripts\windows_install_mingw64.ps1:5 char:1
[00:19:23.962] + Invoke-WebRequest -UseBasicParsing -uri "https://github.com/msys2/msy ...
[00:19:23.962] + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[00:19:23.962]     + CategoryInfo          : NotSpecified: (:) [Invoke-WebRequest], IOExcepti 
[00:19:23.962]    on
[00:19:23.962]     + FullyQualifiedErrorId : System.IO.IOException,Microsoft.PowerShell.Comma 
[00:19:23.962]    nds.InvokeWebRequestCommand

anarazel
anarazel reviewed Feb 1, 2022
View reviewed changes
scripts/windows_install_mingw64.ps1 Show resolved Hide resolved
scripts/windows_install_mingw64.ps1 Outdated Show resolved Hide resolved
scripts/windows_install_mingw64.ps1 Outdated Show resolved Hide resolved
scripts/windows_install_mingw64.ps1 Outdated Show resolved Hide resolved
scripts/windows_install_mingw64.ps1 Outdated Show resolved Hide resolved
@melihmutlu melihmutlu force-pushed the add_mingw branch 2 times, most recently from e16d579 to 46efe75 Compare February 9, 2022 12:38
anarazel
anarazel requested changes Feb 9, 2022
View reviewed changes
.cirrus.yml Outdated Show resolved Hide resolved
.cirrus.yml Outdated Show resolved Hide resolved
.cirrus.yml Outdated Show resolved Hide resolved
@anarazel
Copy link
Owner

To make the tests pass I needed to rebase (for cbdc433). As you allowed the branch to be updated, I rebased, removed a few trailing whitespaces, and squashed the changes.

@anarazel anarazel merged commit c5de350 into anarazel:main Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anarazel anarazel anarazel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@melihmutlu @anarazel