ARROW-4997: [C#] ArrowStreamReader doesn't consume whole stream and doesn't implement sync read. #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sync read. When reading from a network stream, ArrowStreamReader doesn't check how many bytes were read, and instead assumes the whole buffer was filled with a single read call. Fixing this to read multiple times to fill the whole buffer. Also, when consuming a stream only the async read method works. The synchronous method throws NotImplementedException. Implementing the sync method.
stephentoub
reviewed
Mar 22, 2019
stephentoub
reviewed
Mar 22, 2019
stephentoub
approved these changes
Mar 22, 2019
Make EnsureRead method not async. Use ValueTask internally where appropriate.
kszucs
pushed a commit
that referenced
this pull request
Mar 24, 2019
…oesn't implement sync read. When reading from a network stream, ArrowStreamReader doesn't check how many bytes were read, and instead assumes the whole buffer was filled with a single read call. Fixing this to read multiple times to fill the whole buffer. Also, when consuming a stream only the async read method works. The synchronous method throws NotImplementedException. Implementing the sync method. Note: this implements a lot of the underlying functionality from #3925. The difference here is that this change doesn't attempt to solve the perf issues with allocating and copying memory multiples times. #3925 is specifically solving that perf issue. @stephentoub @pgovind @chutchinson Author: Eric Erhardt <eric.erhardt@microsoft.com> Closes #4017 from eerhardt/ArrowReaderBlockingIssues and squashes the following commits: 806a0d3 <Eric Erhardt> PR feedback 356a861 <Eric Erhardt> ArrowStreamReader doesn't consume whole stream and doesn't implement sync read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading from a network stream, ArrowStreamReader doesn't check how many bytes were read, and instead assumes the whole buffer was filled with a single read call. Fixing this to read multiple times to fill the whole buffer.
Also, when consuming a stream only the async read method works. The synchronous method throws NotImplementedException. Implementing the sync method.
Note: this implements a lot of the underlying functionality from #3925. The difference here is that this change doesn't attempt to solve the perf issues with allocating and copying memory multiples times. #3925 is specifically solving that perf issue.
@stephentoub @pgovind @chutchinson