AzureMonitor: map more units #26990
Merged
AzureMonitor: map more units #26990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix link
kylebrandt
added
datasource/Azure
kylebrandt
requested review from
aknuds1 and
wbrowne
and removed request for
a team
|
Is this still WIP? |
kylebrandt
changed the title
aknuds1
pushed a commit
that referenced
this pull request
Aug 14, 2020
add BitsPerSecond and Seconds
wbrowne
pushed a commit
that referenced
this pull request
Aug 20, 2020
add BitsPerSecond and Seconds (cherry picked from commit f9f60c9)
Merged
wbrowne
pushed a commit
that referenced
this pull request
Aug 20, 2020
add BitsPerSecond and Seconds (cherry picked from commit f9f60c9)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
More Azure monitor units need to be mapped to their Grafana values. In particular BitsPerSecond, but should take care of everything listed in https://docs.microsoft.com/en-us/rest/api/monitor/metrics/list#unit