AzureMonitor: select plugin route from cloudname #27273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebrandt
added
area/backend
datasource/Azure
kylebrandt
requested review from
wbrowne and
marefr
and removed request for
a team
marefr
reviewed
Aug 31, 2020
| var azureMonitorRoute *plugins.AppPluginRoute | ||
| for _, route := range plugin.Routes { | ||
| if route.Path == "azuremonitor" { | ||
| if strings.Contains(route.Path, cloudName) { |
There was a problem hiding this comment.
Shouldn't it still be equals here?
There was a problem hiding this comment.
Yes, I think somehow I confused myself when looking at the plugin json and where cloudName comes from in the context of the different services.
marefr
approved these changes
Aug 31, 2020
pull bot
pushed a commit
to digitalocean/grafana
that referenced
this pull request
Aug 31, 2020
* AzureMonitor: select plugin route from cloudname fixes grafana#27243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For the Azure Monitor service the Azure Monitor data source, selects the plugin route.
Which issue(s) this PR fixes:
maybe fixes #27243
Notes for Reviewer
#27243 (comment) explains this