Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure/Insights: Fix handling of legacy dimension values #27513

Merged
merged 1 commit into from Sep 10, 2020
Merged

Conversation

marefr
Copy link
Member

@marefr marefr commented Sep 10, 2020

What this PR does / why we need it:
Properly handle legacy dimension values in the backend.

Which issue(s) this PR fixes:
Fixes #27512

Special notes for your reviewer:

@marefr marefr added this to the 7.2.0-beta2 milestone Sep 10, 2020
@marefr marefr requested a review from a team as a code owner September 10, 2020 15:39
@marefr marefr requested review from wbrowne and kylebrandt and removed request for a team September 10, 2020 15:39
@marefr marefr changed the title Azure/Insights: Fix handling of none dimension values Azure/Insights: Fix handling of legacy dimension values Sep 10, 2020
Copy link
Contributor

@kylebrandt kylebrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@marefr marefr merged commit e85b266 into master Sep 10, 2020
@marefr marefr deleted the 27512_fix branch September 10, 2020 16:21
hugohaggmark pushed a commit that referenced this pull request Sep 17, 2020
Properly handle legacy dimension values in the backend.

Fixes #27512

(cherry picked from commit e85b266)
hugohaggmark pushed a commit that referenced this pull request Sep 17, 2020
Properly handle legacy dimension values in the backend.

Fixes #27512

(cherry picked from commit e85b266)
ryantxu pushed a commit that referenced this pull request Nov 18, 2020
Properly handle legacy dimension values in the backend.

Fixes #27512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure application insights cannot handle a dimension value of none
3 participants