Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureMonitor: Pass through null values instead of setting 0 #28126

Merged
merged 1 commit into from Oct 9, 2020

Conversation

kylebrandt
Copy link
Contributor

What this PR does / why we need it:
For the Azure Monitor service in the Azure Monitor datasource, if values were null the backend set them to zero. They will now be null instead.

Before:
image

After:
image

(One could still use "Null point mode: null as zero" if one wants to make it look like it did before)

Which issue(s) this PR fixes:

Fixes #28001

Special notes for your reviewer:

@kylebrandt kylebrandt added this to the 7.3 milestone Oct 8, 2020
@kylebrandt kylebrandt marked this pull request as ready for review October 8, 2020 18:39
@kylebrandt kylebrandt requested a review from a team as a code owner October 8, 2020 18:39
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylebrandt kylebrandt merged commit c9a5d1a into master Oct 9, 2020
@kylebrandt kylebrandt deleted the azMonNull branch October 9, 2020 12:15
@wbrowne wbrowne changed the title AzureMonitor: pass through null values instead of setting 0 AzureMonitor: Pass through null values instead of setting 0 Oct 14, 2020
@wbrowne wbrowne mentioned this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Monitor Metrics sometimes go to 0
3 participants