Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example 17: "Hands Test" is missing #80

Closed
bmitchinson opened this issue Oct 24, 2020 · 4 comments
Closed

Example 17: "Hands Test" is missing #80

bmitchinson opened this issue Oct 24, 2020 · 4 comments
Labels
help wanted

Comments

@bmitchinson
Copy link

Would love to help update the link to example 17 but can't seem to find it anywhere? Has this example been removed?

Ref: https://cabanier.github.io/webxr-samples/ # 17
@Yonet
Copy link
Member

Yonet commented Nov 7, 2020

@bmitchinson, we need to add a new hand example. Feel free to make a pull request if you have it. Thanks!

@bmitchinson
Copy link
Author

Sounds good I'll take a look, maybe in the mean time we could at least mark examples that don't exist with a note?

@Yonet
Copy link
Member

Yonet commented Dec 8, 2020 •
edited

@bmitchinson I just noticed the example you are looking for is not on immersive-web examples because it is on here: https://github.com/cabanier/webxr-samples.
For the Immersive-web samples on this repo: https://immersive-web.github.io/webxr-samples/
You are still welcomed to do a PR with an example but there are still breaking changes on the hands spec and that might be the reason cabanier haven't made a PR with the example.
Thanks!

@cabanier
Copy link
Member

The hands test is on the main samples page: https://immersive-web.github.io/webxr-samples/immersive-hands.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cabanier @Yonet @bmitchinson