Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop hyperkube use from local-up-cluster.sh #81268

Merged
merged 1 commit into from Sep 18, 2019
Merged

Drop hyperkube use from local-up-cluster.sh #81268

merged 1 commit into from Sep 18, 2019

Conversation

dims
Copy link
Member

@dims dims commented Aug 11, 2019

We should just use the regular binaries used everywhere else and drop
hyperkube. Only the local-up-cluster related CI jobs use hyperkube at
the moment, so this will help deprecate and eliminate hyperkube at least
from the main kubernetes repository.

Change-Id: Ic53a4b56420565f546ac75be6cc23d214766c057

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@dims
Drop hyperkube use from local-up-cluster.sh
549492f 
We should just use the regular binaries used everywhere else and drop
hyperkube. Only the local-up-cluster related CI jobs use hyperkube at
the moment, so this will help deprecate and eliminate hyperkube at least
from the main kubernetes repository.

Change-Id: Ic53a4b56420565f546ac75be6cc23d214766c057
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2019
@dims
Copy link
Member Author

dims commented Aug 11, 2019

/priority important-soon
/sig release
/sig testing

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 11, 2019
@dims
Copy link
Member Author

dims commented Aug 11, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@dims
Copy link
Member Author

dims commented Aug 11, 2019

/retest

@dims
Copy link
Member Author

dims commented Aug 11, 2019

/test pull-kubernetes-integration

1 similar comment
@dims
Copy link
Member Author

dims commented Aug 11, 2019

/test pull-kubernetes-integration

@dims
Copy link
Member Author

dims commented Aug 11, 2019

/test pull-kubernetes-local-e2e

@neolit123
Copy link
Member

neolit123 commented Aug 11, 2019 •
edited

/lgtm
/hold
(for review, feel free to unhold)

btw, should we add a release note for this type of change?

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 11, 2019
@neolit123
Copy link
Member

neolit123 commented Aug 11, 2019 •
edited

found this in the logs:

I0811 17:25:36.825] make: Leaving directory '/go/src/k8s.io/kubernetes'
W0811 17:26:10.410] 2019/08/11 17:26:10 process.go:153: Running: pkill hyperkube
W0811 17:26:10.440] 2019/08/11 17:26:10 process.go:155: Step 'pkill hyperkube' finished in 29.608797ms
W0811 17:26:10.440] 2019/08/11 17:26:10 local.go:225: unable to kill hyperkube processes: error during pkill hyperkube: exit status 1

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/81268/pull-kubernetes-local-e2e/1160600567949561856/

@dims
Copy link
Member Author

dims commented Aug 11, 2019

/test pull-kubernetes-local-e2e

@dims
Copy link
Member Author

dims commented Aug 11, 2019

@neolit123 looks like we have to fix that in test-infra repo:
https://github.com/kubernetes/test-infra/blob/master/kubetest/local.go#L223

@dims dims mentioned this pull request Aug 11, 2019
Merged
@dims
Copy link
Member Author

dims commented Aug 11, 2019

@neolit123 we don't ship this and we don't tell users to use this (devs only). so we should be good here.

@neolit123
Copy link
Member

yes, agreed.

@tpepper
Copy link
Member

tpepper commented Aug 12, 2019 •
edited

@dims do you intend to cherry pick this to the three patch branches? Won't k/test-infra/kubetest run the older branches' local-cluster-up.sh and expect a hyperkube?

@neolit123
Copy link
Member

neolit123 commented Aug 12, 2019 •
edited

Won't k/test-infra/kubetest run the older branches' local-cluster-up.sh and expect a hyperkube?

AFAIK, in terms of our CI, not if the appropriate versioned kubekins image (that hosts kubetest) is used. but this change might break someone that tries to use a standalone recent (e.g. build from test-infra master) kubetest against an older branch of k/k.

@neolit123
Copy link
Member

my suggestion on the mailing list was - announce hyperkube deprecation and give it at least 1 release for removal. but given hyperkube is used in production we should probably apply the GA deprecation rules on it.

@PatrickLang PatrickLang mentioned this pull request Aug 22, 2019
Closed
@dims
Copy link
Member Author

dims commented Aug 28, 2019

/retest

@dims
Copy link
Member Author

dims commented Aug 30, 2019

/override pull-kubernetes-local-e2e

@k8s-ci-robot
Copy link
Contributor

@dims: dims unauthorized: /override is restricted to repo administrators

In response to this:

/override pull-kubernetes-local-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member Author

dims commented Aug 30, 2019

/test pull-kubernetes-local-e2e

@k8s-ci-robot
Copy link
Contributor

@dims: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e 549492f link /test pull-kubernetes-local-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhlhahaha zhlhahaha mentioned this pull request Sep 18, 2019
Merged
@dims
Copy link
Member Author

dims commented Sep 18, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 287f462 into kubernetes:master Sep 18, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dims @k8s-ci-robot @neolit123 @tpepper