Add close-primes detection via Fermat's factorization #5853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
requested changes
Dec 14, 2021
jsha
reviewed
Dec 14, 2021
Co-authored-by: Jacob Hoffman-Andrews <github@hoffman-andrews.com>
jsha
previously approved these changes
Dec 14, 2021
jsha
previously approved these changes
Dec 14, 2021
beautifulentropy
previously approved these changes
Dec 14, 2021
aarongable
dismissed stale reviews from beautifulentropy and jsha
via
248fa97
jsha
approved these changes
Dec 14, 2021
beautifulentropy
approved these changes
Dec 14, 2021
|
Looks fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new check to GoodKey which attempts to factor the public modulus
of the presented key using Fermat's factorization method. This method
will succeed if and only if the prime factors are very close to each
other -- i.e. almost certainly were not selected independently from a
random uniform distribution, but were instead calculated via some other
less secure method.
To support this new feature, add a new config flag to the RA, CA, and
WFE, which all use the GoodKey checks. As part of adding this new config
value, refactor the GoodKey config items into their own config struct
which can be re-used across all services.
If the new
FermatRoundsconfig value has not been set, it will defaultto zero, causing no factorization to be attempted.
Fixes #5850
Part of #5851