Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Android CI support #29406

Merged
merged 63 commits into from Apr 25, 2023
Merged

[vcpkg] Android CI support #29406

merged 63 commits into from Apr 25, 2023

Conversation

dan-shaw
Copy link
Contributor

@dan-shaw dan-shaw commented Feb 3, 2023

No description provided.

@dan-shaw dan-shaw marked this pull request as draft February 3, 2023 00:35
github-actions[bot]
github-actions bot previously approved these changes Feb 3, 2023
@dan-shaw
Copy link
Contributor Author

dan-shaw commented Feb 3, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

github-actions[bot]
github-actions bot previously approved these changes Feb 3, 2023
github-actions[bot]
github-actions bot previously approved these changes Feb 3, 2023
github-actions[bot]
github-actions bot previously approved these changes Feb 3, 2023
github-actions[bot]
github-actions bot previously approved these changes Feb 3, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Feb 3, 2023

A non-windows cross-build finally!

@LilyWangLL LilyWangLL added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Feb 3, 2023
github-actions[bot]
github-actions bot previously approved these changes Feb 4, 2023
github-actions[bot]
github-actions bot previously approved these changes Feb 4, 2023
github-actions[bot]
github-actions bot previously approved these changes Feb 4, 2023
BillyONeal
BillyONeal previously approved these changes Apr 21, 2023
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@@ -104,7 +105,7 @@ if ([string]::IsNullOrWhiteSpace($BinarySourceStub)) {
$cachingArgs += @("--binarysource=clear;$BinarySourceStub,$binaryCachingMode")
}

if ($Triplet -eq 'x64-linux') {
if ($IsLinuxHost) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ($IsLinuxHost) {
if ($IsLinux) {

This is a powershell built-in to determine the host OS -- we don't need to determine it ourselves.

Param(
[parameter(Mandatory=$false)]
[string]$Prefix = "Lin-",
[parameter(Mandatory=$false)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[parameter(Mandatory=$false)]
[parameter(Mandatory=$true)]

steps:
# Note: /mnt is the Azure machines' temporary disk.
- bash: |
curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in the provision script?

Or: should we move the docker installation here so we can use common images :)

sudo mkdir ${{ variables.WORKING_ROOT }} -m=777
sudo rm -rf ${{ variables.WORKING_ROOT }}/failure-logs
sudo mkdir ${{ variables.WORKING_ROOT }}/failure-logs -m=777
sudo mkdir ${{ variables.VCPKG_DOWNLOADS }} -m=777
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to do this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linux ones also do this. I had problems to no end when we first switched to ADO due to permissions 'fun' crossing into the temp disk mount point

ras0219-msft
ras0219-msft previously approved these changes Apr 21, 2023
--user $USER \
--mount type=bind,source=$(Build.Repository.LocalPath),target=/vcpkg \
--mount type=bind,source=$(WORKING_ROOT)/failure-logs,target=/vcpkg/failure-logs \
--mount type=bind,source=/mnt/vcpkg-ci,target=/mnt/vcpkg-ci \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--mount type=bind,source=/mnt/vcpkg-ci,target=/mnt/vcpkg-ci \
--mount type=bind,source=$(WORKING_ROOT),target=/mnt/vcpkg-ci \

./scripts/azure-pipelines/bootstrap-from-source.sh ${{ parameters.vcpkgToolSha }}
displayName: "Build vcpkg with CMake"
condition: ne('use default', '${{ parameters.vcpkgToolSha }}')
- bash: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be copied before the bootstrap step as well?

@dan-shaw dan-shaw merged commit 5787cfa into microsoft:master Apr 25, 2023
15 checks passed
@dg0yt
Copy link
Contributor

dg0yt commented Apr 25, 2023

🚀 🥇

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Apr 25, 2023
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Apr 28, 2023
* Entries at the end reordered to where they go.
* Entries starting with 'g' were scrambled.

Partially complete CI run results: https://dev.azure.com/vcpkg/public/_build/results?buildId=88831

PASSING, REMOVE FROM FAIL LIST: fbgemm:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).

I'm not going to bother figuring out specifically which commit fixed these because this is the first normal full CI run including Android, and it could be any amount of skew that happened while microsoft#29406 was in development.

REGRESSION: cairo:x64-android failed with BUILD_FAILED. If expected, add cairo:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:arm-neon-android failed with BUILD_FAILED. If expected, add fltk:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:arm64-android failed with BUILD_FAILED. If expected, add fltk:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:x64-android failed with BUILD_FAILED. If expected, add fltk:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:arm-neon-android failed with BUILD_FAILED. If expected, add nana:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:arm64-android failed with BUILD_FAILED. If expected, add nana:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:x64-android failed with BUILD_FAILED. If expected, add nana:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

Previously blocked by fontconfig.

REGRESSION: freerdp:x64-android failed with BUILD_FAILED. If expected, add freerdp:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:arm-neon-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:arm64-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:x64-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:arm-neon-android failed with BUILD_FAILED. If expected, add gstreamer:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:arm64-android failed with BUILD_FAILED. If expected, add gstreamer:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:x64-android failed with BUILD_FAILED. If expected, add gstreamer:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:arm-neon-android failed with BUILD_FAILED. If expected, add gts:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:arm64-android failed with BUILD_FAILED. If expected, add gts:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:x64-android failed with BUILD_FAILED. If expected, add gts:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:arm-neon-android failed with BUILD_FAILED. If expected, add lcm:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:arm64-android failed with BUILD_FAILED. If expected, add lcm:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:x64-android failed with BUILD_FAILED. If expected, add lcm:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:arm-neon-android failed with BUILD_FAILED. If expected, add libgpod:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:arm64-android failed with BUILD_FAILED. If expected, add libgpod:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:x64-android failed with BUILD_FAILED. If expected, add libgpod:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:arm-neon-android failed with BUILD_FAILED. If expected, add openscap:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:arm64-android failed with BUILD_FAILED. If expected, add openscap:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:x64-android failed with BUILD_FAILED. If expected, add openscap:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

Previously blocked by glib

REGRESSION: qt5-base:arm-neon-android failed with BUILD_FAILED. If expected, add qt5-base:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: qt5-base:arm64-android failed with BUILD_FAILED. If expected, add qt5-base:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: qt5-base:x64-android failed with BUILD_FAILED. If expected, add qt5-base:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

In the PR that added Android to ci, qt5-base was a cascade because harfbuzz was a cascade: https://dev.azure.com/vcpkg/public/_build/results?buildId=88710 . Possible stealth merge conflict with microsoft#30852 which might have fixed harfbuzz?

REGRESSION: urho3d:x64-linux failed with BUILD_FAILED. If expected, add urho3d:x64-linux=fail to /agent/_work/1/s/scripts/azure-pipelines/../ci.baseline.txt.

Fixed by microsoft#31147
BillyONeal added a commit that referenced this pull request Apr 28, 2023
* Also fixed ordering issues:

* Entries at the end reordered to where they go.
* Entries starting with 'g' were scrambled.

Partially complete CI run results: https://dev.azure.com/vcpkg/public/_build/results?buildId=88831

PASSING, REMOVE FROM FAIL LIST: fbgemm:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).

I'm not going to bother figuring out specifically which commit fixed these because this is the first normal full CI run including Android, and it could be any amount of skew that happened while #29406 was in development.

REGRESSION: cairo:x64-android failed with BUILD_FAILED. If expected, add cairo:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:arm-neon-android failed with BUILD_FAILED. If expected, add fltk:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:arm64-android failed with BUILD_FAILED. If expected, add fltk:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:x64-android failed with BUILD_FAILED. If expected, add fltk:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:arm-neon-android failed with BUILD_FAILED. If expected, add nana:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:arm64-android failed with BUILD_FAILED. If expected, add nana:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:x64-android failed with BUILD_FAILED. If expected, add nana:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

Previously blocked by fontconfig.

REGRESSION: freerdp:x64-android failed with BUILD_FAILED. If expected, add freerdp:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:arm-neon-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:arm64-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:x64-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:arm-neon-android failed with BUILD_FAILED. If expected, add gstreamer:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:arm64-android failed with BUILD_FAILED. If expected, add gstreamer:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:x64-android failed with BUILD_FAILED. If expected, add gstreamer:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:arm-neon-android failed with BUILD_FAILED. If expected, add gts:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:arm64-android failed with BUILD_FAILED. If expected, add gts:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:x64-android failed with BUILD_FAILED. If expected, add gts:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:arm-neon-android failed with BUILD_FAILED. If expected, add lcm:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:arm64-android failed with BUILD_FAILED. If expected, add lcm:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:x64-android failed with BUILD_FAILED. If expected, add lcm:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:arm-neon-android failed with BUILD_FAILED. If expected, add libgpod:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:arm64-android failed with BUILD_FAILED. If expected, add libgpod:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:x64-android failed with BUILD_FAILED. If expected, add libgpod:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:arm-neon-android failed with BUILD_FAILED. If expected, add openscap:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:arm64-android failed with BUILD_FAILED. If expected, add openscap:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:x64-android failed with BUILD_FAILED. If expected, add openscap:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

Previously blocked by glib

REGRESSION: qt5-base:arm-neon-android failed with BUILD_FAILED. If expected, add qt5-base:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: qt5-base:arm64-android failed with BUILD_FAILED. If expected, add qt5-base:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: qt5-base:x64-android failed with BUILD_FAILED. If expected, add qt5-base:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

In the PR that added Android to ci, qt5-base was a cascade because harfbuzz was a cascade: https://dev.azure.com/vcpkg/public/_build/results?buildId=88710 . Possible stealth merge conflict with #30852 which might have fixed harfbuzz?

REGRESSION: urho3d:x64-linux failed with BUILD_FAILED. If expected, add urho3d:x64-linux=fail to /agent/_work/1/s/scripts/azure-pipelines/../ci.baseline.txt.

Fixed by #31147

* Also fix zeroc-ice order.
vicroms pushed a commit that referenced this pull request Mar 1, 2024
Passing on
https://dev.azure.com/vcpkg/public/_build/results?buildId=99959&view=results.

Added `openblas` to ci.baseline.txt by
#29406, which has been fixed by
#36072:
```
PASSING, REMOVE FROM FAIL LIST: openblas:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: openblas:arm64-android
```

Add the following ports to the ci.baseline.txt because they are
direct/indirect downstream of `openblas`:
```
REGRESSION: blas:arm-neon-android failed with BUILD_FAILED. If expected, add blas:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lapack-reference:arm64-android failed with BUILD_FAILED. If expected, add lapack-reference:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: clapack:arm64-android failed with BUILD_FAILED. If expected, add clapack:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: shogun:arm64-android failed with BUILD_FAILED. If expected, add shogun:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
```


- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] ~SHA512s are updated for each updated download.~
- [x] The "supports" clause reflects platforms that may be fixed by this
new version.
- [ ] ~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~
- [ ] ~Any patches that are no longer applied are deleted from the
port's directory.~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

---------

Co-authored-by: Monica <v-liumonica@microsoft.com>
JavierMatosD pushed a commit that referenced this pull request Apr 9, 2024
Passing on
https://dev.azure.com/vcpkg/public/_build/results?buildId=101560&view=results

Added `minio-cpp` to ci.baseline.txt by
#29406, which has been fixed by
#37990.

- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] ~SHA512s are updated for each updated download.~
- [ ] ~The "supports" clause reflects platforms that may be fixed by
this new version.~
- [x] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [ ] ~Any patches that are no longer applied are deleted from the
port's directory.~
- [ ] ~The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.~
- [ ] ~Only one version is added to each modified port's versions file.~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants