[merp] crash reports have Darwin kernel version in OSVersion field #17004

kdubau · 2019-09-23T20:44:37Z

Steps to Reproduce

Induce a crash from VSM (so merp is enabled)
Look at the merp payload available in the merp dialog

Current Behavior

The parameters field currently looks something like this:

        {
		"ApplicationBundleId" : "com.microsoft.visual-studio",
		"ApplicationVersion" : "8.5.0.114",
		"ApplicationBitness" : "x64",
		"ApplicationName" : "Visual Studio",
		"BlameModuleName" : "Mono Exception",
		"BlameModuleVersion" : "6.7.0.562 (master/db626fe9d37 Thu Sep  5 00:00:34 EDT 2
                 .....
		"OSVersion" : "18.7.0",
		"LanguageID" : "0x7f",
		"SystemManufacturer" : "apple",
		"SystemModel" : "MacBookPro15,1",
		"EventType" : "AppleAppCrash"
	}

Notice OS Version is 18.7.0 which is actually the kernel version.

Expected Behavior

I expected the OS Version to be the macOS version, for example 10.14.6. There is no clear mapping of kernel version to OS version as some macOS versions share kernel versions.

I would also be okay with capturing both versions!

On which platforms did you notice this

[x] macOS
[ ] Linux
[ ] Windows

The text was updated successfully, but these errors were encountered:

kdubau · 2019-09-23T20:46:01Z

@leculver if we add another param for the real OS version (or rather add a KernelVersion field) would we need to bump the protocol version?

leculver · 2019-09-23T21:25:54Z

No. As long as it goes into the .json file (not .xml) and doesn't fundamentally change how we use the file we don't need to bump version. Just adding extra parameters and info does not need a version bump.

…

________________________________ From: Kyle White <notifications@github.com> Sent: Monday, September 23, 2019 4:46:28 PM To: mono/mono <mono@noreply.github.com> Cc: Lee Culver <leculver@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [mono/mono] [merp] crash reports have Darwin kernel version in OSVersion field (#17004) @leculver<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fleculver&data=02%7C01%7Cleculver%40microsoft.com%7Cc1d5b9df0c9e48c1953a08d740671b95%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637048683892650592&sdata=e9JYo%2FtbJ%2BYhS2rtv7H%2BYkMn54s3RXjmgH%2FxdAq617E%3D&reserved=0> if we add another param for the real OS version (or rather add a KernelVersion field) would we need to bump the protocol version? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmono%2Fmono%2Fissues%2F17004%3Femail_source%3Dnotifications%26email_token%3DACA2L7ZTO4NN4S2NB4I3EPDQLETKJA5CNFSM4IZR3GF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MGZII%23issuecomment-534277281&data=02%7C01%7Cleculver%40microsoft.com%7Cc1d5b9df0c9e48c1953a08d740671b95%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637048683892650592&sdata=aMmeWFVtitTprCtlX%2F0uN%2BfjfJ7sLFu%2BdR4hcnPUK5c%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACA2L75AGY44KVIIJXGS6JTQLETKJANCNFSM4IZR3GFQ&data=02%7C01%7Cleculver%40microsoft.com%7Cc1d5b9df0c9e48c1953a08d740671b95%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637048683892660590&sdata=yogSvK1g%2Bl7c9ZGU8ZvZcB9eL0SFENkPoNz3cDwdKII%3D&reserved=0>.

lambdageek · 2019-09-23T22:16:33Z

Turns out it's actually pretty non-trivial to get the product version of OSX from C.

There are two workable options:

Use the deprecated CoreServices Gestalt API
On OSX 10.13.6 or newer use sysctlbyname ("kern.osproductversion", ...)

Source: this SO answer

Here's a sample I cooked up:

/* clang -o uname-test uname-test.c -framework CoreServices */

#include <sys/utsname.h>
#include <stdio.h>
#include <sys/errno.h>
#include <string.h>

#include <CoreServices/CoreServices.h>

#include <sys/sysctl.h>

int GetGestaltProductVersion (void)
{
	SInt32 major,minor,bugFix;

	Gestalt(gestaltSystemVersionMajor, &major);
	Gestalt(gestaltSystemVersionMinor, &minor);
	Gestalt(gestaltSystemVersionBugFix, &bugFix);

	printf("gestalt: %d.%d.%d\n",major,minor,bugFix);    

	return 0;
}

void
GetSysVer (void)
{
	/* 10.13.6 or later */
	const char *q = "kern.osproductversion";
	size_t len = 0;
	if (sysctlbyname (q, NULL, &len, NULL, 0) == -1) {
		printf ("sysctl error: %s\n", strerror (errno));
	} else {
		char *s = malloc (len+1);
		if (sysctlbyname (q, s, &len, NULL, 0) == -1) {
			printf ("2nd sysctl error: %s\n", strerror (errno));
		} else {
			printf ("sysctl version: %s\n", s);
		}
		free (s);
	}
}

int
main (void)
{
	struct utsname name;

	if (uname (&name) >= 0) {
		printf ("release: %s\n", name.release);
		printf ("version: %s\n", name.version);
	} else {
		printf ("%s\n", strerror (errno));
	}

	GetGestaltProductVersion();

	GetSysVer ();
}

Prints this on my machine:

release: 18.7.0
version: Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64
gestalt: 10.14.6
sysctl version: 10.14.6

lambdageek · 2019-09-23T22:23:33Z

@kdubau It would probably be easier for VSfM to grab the OSX product version from C# using NSProcessInfo and pass it to crash reporting in the extra info blob via AnnotateMicrosoftTelemetry.

Apparently in Obj-C it's as simple as:

[[NSProcessInfo processInfo] operatingSystemVersion]

But I don't think we have any Obj-C code in mono proper, not sure how much work it would be to add to our build scripts.

leculver · 2019-09-24T01:58:35Z

We are about to have to do some work in Mono + VS4M to change the eventtype and other parameters for MERP reporting. We could probably wrap this change into our work when we work on the startup path here. Can we leave this issue open for another day or two without resolution? I’m just coming back from vacation and trying to the complicated work we have to do here planned and scheduled. Thanks! From: Aleksey Kliger (λgeek) <notifications@github.com> Sent: Monday, September 23, 2019 3:24 PM To: mono/mono <mono@noreply.github.com> Cc: Lee Culver <leculver@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [mono/mono] [merp] crash reports have Darwin kernel version in OSVersion field (#17004) @kdubau<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkdubau&data=02%7C01%7Cleculver%40microsoft.com%7C9aba5f3809b9454a03eb08d74074bce2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637048742437043775&sdata=rEKKmju5h1PG7AyA75oa16IRuiz4gLm2vwybw0IahE0%3D&reserved=0> It would probably be easier for VSfM to drop grab the OSX product version from C# using NSProcessInfo and pass it to crash reporting in the extra info blob via AnnotateMicrosoftTelemetry. Apparently in Obj-C it's as simple as: [[NSProcessInfo processInfo] operatingSystemVersion] But I don't think we have any Obj-C code in mono proper, not sure how much work it would be to add to our build scripts. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmono%2Fmono%2Fissues%2F17004%3Femail_source%3Dnotifications%26email_token%3DACA2L745HI375LXP2Y4DA2DQLE6YFA5CNFSM4IZR3GF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MOMHY%23issuecomment-534308383&data=02%7C01%7Cleculver%40microsoft.com%7C9aba5f3809b9454a03eb08d74074bce2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637048742437043775&sdata=pLn0e9oSTGMYSWq0VmXqrZAcLPupdX%2BTheGzg3sz%2FbY%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACA2L76UTLKCPXD4UOJRNQ3QLE6YFANCNFSM4IZR3GFQ&data=02%7C01%7Cleculver%40microsoft.com%7C9aba5f3809b9454a03eb08d74074bce2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637048742437053764&sdata=s1REImLtg1ry05pz5vKok472bHHeK0MSTItikZ%2FfDGM%3D&reserved=0>.

jaykrell · 2019-09-24T02:40:21Z

What happens if you just put that snippet in an .m file?

Fixes mono#17004

kdubau · 2019-09-30T19:15:15Z

@lambdageek how about something simple like this? #17130

If we only use AnnotateMicrosoftTelemetry from VSM, we would have to have a well-known key to look it up when uploading, because this value is needed in the XML payload for proper bucketing on the backend.

I think this implementation is a bit cleaner than relying on looking it up in the annotations. For older OS's we will only have the {major}.{minor} but I think it's okay. If we ever needed the patch version for technical reasons, we can additionally use the AnnotateMicrosoftTelemetry to add a full version if we really need it.

kdubau · 2019-09-30T19:18:15Z

Newer macOS versions will have kern.osproductversion and thus give the full version.

Fixes mono#17004

* Use macOS version not Darwin version in MERP Fixes #17004 * Update mono-merp.c Ensure this is only for Mac * Don't allocate in macos_version_string Use a static buffer. Also some formatting fixes.

Fixes mono#17004

…#17147) * Use macOS version not Darwin version in MERP Fixes #17004 * Update mono-merp.c Ensure this is only for Mac * Don't allocate in macos_version_string Use a static buffer. Also some formatting fixes. * Simplify error path code when getting the product version * Add G_STRING_CONSTANT_AND_LENGTH macro Cherrypicked from 8c288f0

Changes: mono/mono@5281037...7dbad3c Context: mono/mono#7377 Context: mono/mono#16570 Context: mono/mono#17004 Context: mono/mono#17151 Context: mono/mono#17180 * mono/mono@7dbad3c3618: [arm] Fix fetching of method addresses (#17253) * mono/mono@9a88a36789e: [sgen] Fix invalid value passed to write barrier (#17247) * mono/mono@0f241c975ce: [2019-08] Add drawing type converters to mobile profiles (#17240) * mono/mono@7ebe1a1763c: Update Roslyn to 3.4.0-beta2-19477-01 * mono/mono@b759449ba8d: Bump msbuild to track mono-2019-08 * mono/mono@617f399efca: [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17211) * mono/mono@77258ea1122: [2019-08] [debugger][exception] Debugger breaks on handled exceptions (#17202) * mono/mono@f83c321f88f: Bump msbuild to track mono-2019-08 (#17193) * mono/mono@1ecd094b44c: [2019-08] [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17077) * mono/mono@54a33be9dee: [merp] Put thread into async context before running summarizer (#17197) * mono/mono@72128bb00d3: Bump libgdiplus to 6.0.4 * mono/mono@65a972c0333: Always do copy_stack_data on entering GC safe/unsafe mode. (#17184) * mono/mono@9e6def1553b: [merp] exit_status is 0 if we ran the uploader successfully (#17187) * mono/mono@8a707cc0124: [2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17189) * mono/mono@bd72952cf82: [2019-08] [merp] Don't overrun buffer in copy_summary_string_safe … (#17178) * mono/mono@b6efc0cc906: Bump msbuild to track xplat-master (#17132) * mono/mono@2869cd5f67e: Bump ikvm to get mono/ikvm-fork#13 (#17170) * mono/mono@a64a25695d6: [2019-08] [merp] Use macOS version not Darwin version in MERP reports (#17147) * mono/mono@57f068438d4: [2019-08] [merp] Add API method that whitelists all native libraries (#17128)

Changes: mono/mono@5281037...df5e13f Context: mono/mono#7377 Context: mono/mono#16570 Context: mono/mono#17004 Context: mono/mono#17151 Context: mono/mono#17180 * mono/mono@df5e13f95df: [tests] Bump corefx to get Azure testhost change (#17275) * mono/mono@11e1499c227: [2019-08] [merp] Print missing status marker file for stage 1 (setup) (#17220) * mono/mono@7dbad3c3618: [arm] Fix fetching of method addresses (#17253) * mono/mono@9a88a36789e: [sgen] Fix invalid value passed to write barrier (#17247) * mono/mono@0f241c975ce: [2019-08] Add drawing type converters to mobile profiles (#17240) * mono/mono@7ebe1a1763c: Update Roslyn to 3.4.0-beta2-19477-01 * mono/mono@b759449ba8d: Bump msbuild to track mono-2019-08 * mono/mono@617f399efca: [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17211) * mono/mono@77258ea1122: [2019-08] [debugger][exception] Debugger breaks on handled exceptions (#17202) * mono/mono@f83c321f88f: Bump msbuild to track mono-2019-08 (#17193) * mono/mono@1ecd094b44c: [2019-08] [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17077) * mono/mono@54a33be9dee: [merp] Put thread into async context before running summarizer (#17197) * mono/mono@72128bb00d3: Bump libgdiplus to 6.0.4 * mono/mono@65a972c0333: Always do copy_stack_data on entering GC safe/unsafe mode. (#17184) * mono/mono@9e6def1553b: [merp] exit_status is 0 if we ran the uploader successfully (#17187) * mono/mono@8a707cc0124: [2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17189) * mono/mono@bd72952cf82: [2019-08] [merp] Don't overrun buffer in copy_summary_string_safe … (#17178) * mono/mono@b6efc0cc906: Bump msbuild to track xplat-master (#17132) * mono/mono@2869cd5f67e: Bump ikvm to get mono/ikvm-fork#13 (#17170) * mono/mono@a64a25695d6: [2019-08] [merp] Use macOS version not Darwin version in MERP reports (#17147) * mono/mono@57f068438d4: [2019-08] [merp] Add API method that whitelists all native libraries (#17128)

Changes: mono/mono@5281037...3eb5f34 Fixes: xamarin#3726 Context: mono/mono@0f241c9 Context: mono/mono#7377 Context: mono/mono#16570 Context: mono/mono#17004 Context: mono/mono#17151 Context: mono/mono#17180 * mono/mono@3eb5f34f541: [GTK] Bump bockbuild for GtkViewport autoscrolling patch. (#17321) * mono/mono@b601371d5f0: Update MERP event type to MonoAppCrash * mono/mono@6184ff007b2: [2019-08][ci] Use Xcode11.1 and 11.2beta2 for XI/XM Mono SDK builds (#17324) * mono/mono@8969f2cc99b: [2019-08] [merp] Include any managed methods in the 'unmanaged_frames' portion (#17316) * mono/mono@30094401081: [2019-08][merp] Don't install SIGTERM handler in EnableMicrosoftTelemetry (#17308) * mono/mono@df5e13f95df: [tests] Bump corefx to get Azure testhost change (#17275) * mono/mono@11e1499c227: [2019-08] [merp] Print missing status marker file for stage 1 (setup) (#17220) * mono/mono@7dbad3c3618: [arm] Fix fetching of method addresses (#17253) * mono/mono@9a88a36789e: [sgen] Fix invalid value passed to write barrier (#17247) * mono/mono@0f241c975ce: [2019-08] Add drawing type converters to mobile profiles (#17240) * mono/mono@7ebe1a1763c: Update Roslyn to 3.4.0-beta2-19477-01 * mono/mono@b759449ba8d: Bump msbuild to track mono-2019-08 * mono/mono@617f399efca: [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17211) * mono/mono@77258ea1122: [2019-08] [debugger][exception] Debugger breaks on handled exceptions (#17202) * mono/mono@f83c321f88f: Bump msbuild to track mono-2019-08 (#17193) * mono/mono@1ecd094b44c: [2019-08] [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17077) * mono/mono@54a33be9dee: [merp] Put thread into async context before running summarizer (#17197) * mono/mono@72128bb00d3: Bump libgdiplus to 6.0.4 * mono/mono@65a972c0333: Always do copy_stack_data on entering GC safe/unsafe mode. (#17184) * mono/mono@9e6def1553b: [merp] exit_status is 0 if we ran the uploader successfully (#17187) * mono/mono@8a707cc0124: [2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17189) * mono/mono@bd72952cf82: [2019-08] [merp] Don't overrun buffer in copy_summary_string_safe … (#17178) * mono/mono@b6efc0cc906: Bump msbuild to track xplat-master (#17132) * mono/mono@2869cd5f67e: Bump ikvm to get mono/ikvm-fork#13 (#17170) * mono/mono@a64a25695d6: [2019-08] [merp] Use macOS version not Darwin version in MERP reports (#17147) * mono/mono@57f068438d4: [2019-08] [merp] Add API method that whitelists all native libraries (#17128)

Changes: https://github.com/mono/mono/compare/528103728fc2aedb7b6062e11255d39a0ed3f31c... df5e13f95df7a2d11d86904e74b1bd8950c9d43b Fixes: #3726 Context: mono/mono@0f241c9 Context: mono/mono#7377 Context: mono/mono#16570 Context: mono/mono#17004 Context: mono/mono#17151 Context: mono/mono#17180 * mono/mono@df5e13f95df: [tests] Bump corefx to get Azure testhost change (#17275) * mono/mono@11e1499c227: [2019-08] [merp] Print missing status marker file for stage 1 (setup) (#17220) * mono/mono@7dbad3c3618: [arm] Fix fetching of method addresses (#17253) * mono/mono@9a88a36789e: [sgen] Fix invalid value passed to write barrier (#17247) * mono/mono@0f241c975ce: [2019-08] Add drawing type converters to mobile profiles (#17240) * mono/mono@7ebe1a1763c: Update Roslyn to 3.4.0-beta2-19477-01 * mono/mono@b759449ba8d: Bump msbuild to track mono-2019-08 * mono/mono@617f399efca: [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17211) * mono/mono@77258ea1122: [2019-08] [debugger][exception] Debugger breaks on handled exceptions (#17202) * mono/mono@f83c321f88f: Bump msbuild to track mono-2019-08 (#17193) * mono/mono@1ecd094b44c: [2019-08] [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17077) * mono/mono@54a33be9dee: [merp] Put thread into async context before running summarizer (#17197) * mono/mono@72128bb00d3: Bump libgdiplus to 6.0.4 * mono/mono@65a972c0333: Always do copy_stack_data on entering GC safe/unsafe mode. (#17184) * mono/mono@9e6def1553b: [merp] exit_status is 0 if we ran the uploader successfully (#17187) * mono/mono@8a707cc0124: [2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17189) * mono/mono@bd72952cf82: [2019-08] [merp] Don't overrun buffer in copy_summary_string_safe … (#17178) * mono/mono@b6efc0cc906: Bump msbuild to track xplat-master (#17132) * mono/mono@2869cd5f67e: Bump ikvm to get mono/ikvm-fork#13 (#17170) * mono/mono@a64a25695d6: [2019-08] [merp] Use macOS version not Darwin version in MERP reports (#17147) * mono/mono@57f068438d4: [2019-08] [merp] Add API method that whitelists all native libraries (#17128)

Changes: mono/mono@5281037...3eb5f34 Fixes: #3726 Context: mono/mono@0f241c9 Context: mono/mono#7377 Context: mono/mono#16570 Context: mono/mono#17004 Context: mono/mono#17151 Context: mono/mono#17180 * mono/mono@3eb5f34f541: [GTK] Bump bockbuild for GtkViewport autoscrolling patch. (#17321) * mono/mono@b601371d5f0: Update MERP event type to MonoAppCrash * mono/mono@6184ff007b2: [2019-08][ci] Use Xcode11.1 and 11.2beta2 for XI/XM Mono SDK builds (#17324) * mono/mono@8969f2cc99b: [2019-08] [merp] Include any managed methods in the 'unmanaged_frames' portion (#17316) * mono/mono@30094401081: [2019-08][merp] Don't install SIGTERM handler in EnableMicrosoftTelemetry (#17308) * mono/mono@df5e13f95df: [tests] Bump corefx to get Azure testhost change (#17275) * mono/mono@11e1499c227: [2019-08] [merp] Print missing status marker file for stage 1 (setup) (#17220) * mono/mono@7dbad3c3618: [arm] Fix fetching of method addresses (#17253) * mono/mono@9a88a36789e: [sgen] Fix invalid value passed to write barrier (#17247) * mono/mono@0f241c975ce: [2019-08] Add drawing type converters to mobile profiles (#17240) * mono/mono@7ebe1a1763c: Update Roslyn to 3.4.0-beta2-19477-01 * mono/mono@b759449ba8d: Bump msbuild to track mono-2019-08 * mono/mono@617f399efca: [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17211) * mono/mono@77258ea1122: [2019-08] [debugger][exception] Debugger breaks on handled exceptions (#17202) * mono/mono@f83c321f88f: Bump msbuild to track mono-2019-08 (#17193) * mono/mono@1ecd094b44c: [2019-08] [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17077) * mono/mono@54a33be9dee: [merp] Put thread into async context before running summarizer (#17197) * mono/mono@72128bb00d3: Bump libgdiplus to 6.0.4 * mono/mono@65a972c0333: Always do copy_stack_data on entering GC safe/unsafe mode. (#17184) * mono/mono@9e6def1553b: [merp] exit_status is 0 if we ran the uploader successfully (#17187) * mono/mono@8a707cc0124: [2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17189) * mono/mono@bd72952cf82: [2019-08] [merp] Don't overrun buffer in copy_summary_string_safe … (#17178) * mono/mono@b6efc0cc906: Bump msbuild to track xplat-master (#17132) * mono/mono@2869cd5f67e: Bump ikvm to get mono/ikvm-fork#13 (#17170) * mono/mono@a64a25695d6: [2019-08] [merp] Use macOS version not Darwin version in MERP reports (#17147) * mono/mono@57f068438d4: [2019-08] [merp] Add API method that whitelists all native libraries (#17128)

Changes: mono/api-snapshot@fc50bc4...45a61d9 $ git diff --shortstat fc50bc4f...45a61d93 22 files changed, 775 insertions(+), 474 deletions(-) Changes: dotnet/cecil@a6c8f5e...a6a7f5c $ git diff --shortstat a6c8f5e1...a6a7f5c0 55 files changed, 818 insertions(+), 530 deletions(-) Changes: mono/corefx@1f87de3...49f1c45 $ git diff --shortstat e4f7102b...49f1c453 38 files changed, 1171 insertions(+), 419 deletions(-) Changes: dotnet/linker@ebe2a1f...e8d054b $ git diff --shortstat ebe2a1f4...e8d054bf 137 files changed, 5360 insertions(+), 1781 deletions(-) Changes: mono/mono@8946e49...18920a8 $ git diff --shortstat 8946e49a...18920a83 1811 files changed, 47240 insertions(+), 48331 deletions(-) Changes: xamarin/xamarin-android-api-compatibility@a61271e...50a3c52 $ git diff --shortstat a61271e0...50a3c52d 1 file changed, 2 insertions(+), 791 deletions(-) Fixes: #3619 Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1005448 Context: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/967582 Context: https://github.com/dotnet/coreclr/issues/26370 Context: https://github.com/dotnet/coreclr/issues/26479 Context: https://github.com/dotnet/corefx/issues/40455 Context: https://github.com/dotnet/corefx/issues/40578 Context: mono/mono#7377 Context: mono/mono#12421 Context: mono/mono#12586 Context: mono/mono#14080 Context: mono/mono#14725 Context: mono/mono#14772 Context: mono/mono#15261 Context: mono/mono#15262 Context: mono/mono#15263 Context: mono/mono#15307 Context: mono/mono#15308 Context: mono/mono#15310 Context: mono/mono#15646 Context: mono/mono#15687 Context: mono/mono#15805 Context: mono/mono#15992 Context: mono/mono#15994 Context: mono/mono#15999 Context: mono/mono#16032 Context: mono/mono#16034 Context: mono/mono#16046 Context: mono/mono#16192 Context: mono/mono#16308 Context: mono/mono#16310 Context: mono/mono#16369 Context: mono/mono#16380 Context: mono/mono#16381 Context: mono/mono#16395 Context: mono/mono#16411 Context: mono/mono#16415 Context: mono/mono#16486 Context: mono/mono#16570 Context: mono/mono#16605 Context: mono/mono#16616 Context: mono/mono#16689 Context: mono/mono#16701 Context: mono/mono#16712 Context: mono/mono#16742 Context: mono/mono#16759 Context: mono/mono#16803 Context: mono/mono#16808 Context: mono/mono#16824 Context: mono/mono#16876 Context: mono/mono#16879 Context: mono/mono#16918 Context: mono/mono#16943 Context: mono/mono#16950 Context: mono/mono#16974 Context: mono/mono#17004 Context: mono/mono#17017 Context: mono/mono#17038 Context: mono/mono#17040 Context: mono/mono#17083 Context: mono/mono#17084 Context: mono/mono#17133 Context: mono/mono#17139 Context: mono/mono#17151 Context: mono/mono#17180 Context: mono/mono#17278 Context: mono/mono#17549 Context: mono/mono#17569 Context: mono/mono#17665 Context: mono/mono#17687 Context: mono/mono#17737 Context: mono/mono#17790 Context: mono/mono#17924 Context: mono/mono#17931 Context: https://github.com/mono/mono/issues/26758 Context: https://github.com/mono/mono/issues/37913 Context: xamarin/xamarin-macios#7005

…o#17130) * Use macOS version not Darwin version in MERP Fixes mono/mono#17004 * Update mono-merp.c Ensure this is only for Mac * Don't allocate in macos_version_string Use a static buffer. Also some formatting fixes. Commit migrated from mono/mono@0004522

lambdageek added the area-Runtime: Crash Reporting label Sep 23, 2019

marek-safar added the proposal label Sep 24, 2019

kdubau added a commit to kdubau/mono that referenced this issue Sep 30, 2019

Use macOS version not Darwin version in MERP

b7f0202

Fixes mono#17004

kdubau mentioned this issue Sep 30, 2019

[merp] Use macOS version not Darwin version in MERP reports #17130

Merged

kdubau added a commit to kdubau/mono that referenced this issue Sep 30, 2019

Use macOS version not Darwin version in MERP Fixes mono#17004

442d482

kdubau added a commit to kdubau/mono that referenced this issue Sep 30, 2019

Use macOS version not Darwin version in MERP

fdced96

Fixes mono#17004

lambdageek closed this as completed in #17130 Oct 2, 2019

monojenkins pushed a commit to monojenkins/mono that referenced this issue Oct 2, 2019

Use macOS version not Darwin version in MERP

74f18c5

Fixes mono#17004

monojenkins mentioned this issue Oct 2, 2019

[2019-08] [merp] Use macOS version not Darwin version in MERP reports #17147

Merged

jonpryor mentioned this issue Oct 10, 2019

Bump to mono/mono/2019-08@3eb5f34f xamarin/xamarin-android#3764

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[merp] crash reports have Darwin kernel version in OSVersion field #17004

[merp] crash reports have Darwin kernel version in OSVersion field #17004

kdubau commented Sep 23, 2019 •

edited

kdubau commented Sep 23, 2019

leculver commented Sep 23, 2019 via email

lambdageek commented Sep 23, 2019

lambdageek commented Sep 23, 2019 •

edited

leculver commented Sep 24, 2019 via email

jaykrell commented Sep 24, 2019

kdubau commented Sep 30, 2019

kdubau commented Sep 30, 2019

[merp] crash reports have Darwin kernel version in OSVersion field #17004

[merp] crash reports have Darwin kernel version in OSVersion field #17004

Comments

kdubau commented Sep 23, 2019 • edited

Steps to Reproduce

Current Behavior

Expected Behavior

On which platforms did you notice this

kdubau commented Sep 23, 2019

leculver commented Sep 23, 2019 via email

lambdageek commented Sep 23, 2019

lambdageek commented Sep 23, 2019 • edited

leculver commented Sep 24, 2019 via email

jaykrell commented Sep 24, 2019

kdubau commented Sep 30, 2019

kdubau commented Sep 30, 2019

kdubau commented Sep 23, 2019 •

edited

lambdageek commented Sep 23, 2019 •

edited