Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing constraint: result.ruleId == result.rule.id #429

Closed
ghost opened this issue Jun 15, 2019 · 1 comment
Closed

Add missing constraint: result.ruleId == result.rule.id #429

ghost opened this issue Jun 15, 2019 · 1 comment
Labels
2.1.0-CSD.1-TC-comment Comment submitted by a TC member during CSD.1 public comment period for SARIF v2.1.0.. bug resolved-fixed

Comments

@ghost
Copy link

ghost commented Jun 15, 2019

The spec correctly says that if result.ruleIndex and result.rule.index are both present, they must be equal. But it does not say that if result.ruleId and result.rule.id are both present, they must be equal. It should say that.

@ghost ghost added bug 2.1.0-CSD.1-TC-comment Comment submitted by a TC member during CSD.1 public comment period for SARIF v2.1.0.. labels Jun 15, 2019
@ghost ghost self-assigned this Jul 7, 2019
@ghost ghost added the resolved-fixed label Jul 7, 2019
@ghost ghost changed the title Missing constraint: result.ruleId == result.rule.id Add missing constraint: result.ruleId == result.rule.id Jul 7, 2019
@ghost
Copy link
Author

ghost commented Aug 5, 2019

I neglected to close this when I marked it resolved-fixed.

@ghost ghost closed this as completed Aug 5, 2019
@oasis-tcs oasis-tcs deleted a comment from Rpsboogie Dec 15, 2023
@oasis-tcs oasis-tcs deleted a comment from Hawkmike Dec 15, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.0-CSD.1-TC-comment Comment submitted by a TC member during CSD.1 public comment period for SARIF v2.1.0.. bug resolved-fixed
Projects
None yet
Development

No branches or pull requests

0 participants