Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix result.rule.description in the schema #437

Closed
ghost opened this issue Aug 27, 2019 · 0 comments
Closed

Fix result.rule.description in the schema #437

ghost opened this issue Aug 27, 2019 · 0 comments
Labels
bug impact-documentation-only non-substantive Change falls under editorial discretion resolved-fixed

Comments

@ghost
Copy link

ghost commented Aug 27, 2019

In the SARIF schema, result.ruleId.description is

The stable, unique identifier of the rule, if any, to which this notification is relevant. This member can be used to retrieve rule metadata from the rules dictionary, if it exists.

  • In the first sentence, it should say "to which this result is relevant".
  • The second sentence should be removed. The spec is clear that rule lookup is done by ruleIndex, not by ruleId.
@ghost ghost added bug impact-documentation-only non-substantive Change falls under editorial discretion labels Aug 27, 2019
@ghost ghost self-assigned this Feb 21, 2020
@ghost ghost added the resolved-fixed label Feb 21, 2020
@ghost ghost closed this as completed Feb 21, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug impact-documentation-only non-substantive Change falls under editorial discretion resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants