Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of v2.1.0 JSON schema #448

Closed
lcartey opened this issue Jan 6, 2020 · 3 comments
Closed

Duplication of v2.1.0 JSON schema #448

lcartey opened this issue Jan 6, 2020 · 3 comments
Labels
2.1.0-candidate-standard-TC-comment Comment submitted by TC member during 60-day OASIS Candidate Standard comment period for SARIF 2.1.0 resolved-by-design

Comments

@lcartey
Copy link

lcartey commented Jan 6, 2020

The v2.1.0 schema is duplicated in two places in the repository:

https://github.com/oasis-tcs/sarif-spec/blob/master/Schemata/sarif-schema-2.1.0.json
https://github.com/oasis-tcs/sarif-spec/blob/master/Documents/CommitteeSpecifications/2.1.0/sarif-schema-2.1.0.json

Furthermore, they are not byte-for-byte identical - the former uses CRLF line endings, whereas the latter uses LF line endings.

Do we need two copies? If so, can we make them identical?

@ghost ghost self-assigned this Feb 21, 2020
@ghost ghost added the 2.1.0-candidate-standard-TC-comment Comment submitted by TC member during 60-day OASIS Candidate Standard comment period for SARIF 2.1.0 label Feb 21, 2020
@ghost
Copy link

ghost commented Feb 21, 2020

@lcartey @michaelcfanning

There are multiple copies because we drop a copy into the folder for each publicly reviewed version. That copy is the version as it existed at the time we opened the ballot. There will be still yet another copy for the final version we send out in the "call for consent".

The LF version is correct (and it took a little git config juggling for me to get it there in that form). When all is done, I'll copy the final balloted version over the one in the Schemata folder. I'll leave this issue open in the meantime.

@michaelcfanning
Copy link
Contributor

@lgoding, I believe we are finished here? if so, can we close this?

@ghost
Copy link

ghost commented Mar 7, 2020

Yes, all the right things are in all the right places.

@ghost ghost closed this as completed Mar 7, 2020
@ghost ghost added the resolved-by-design label Mar 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.0-candidate-standard-TC-comment Comment submitted by TC member during 60-day OASIS Candidate Standard comment period for SARIF 2.1.0 resolved-by-design
Projects
None yet
Development

No branches or pull requests

2 participants