Add attribute to get port debug data #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
approved these changes
Oct 18, 2021
mikeberesford
force-pushed
the
port_debug
branch
2 times, most recently
from
ee47910
to
e1b1eee
Compare
mikeberesford
commented
Jan 26, 2023
JaiOCP
approved these changes
Jan 26, 2023
mikeberesford
force-pushed
the
port_debug
branch
2 times, most recently
from
dc7077b
to
8576a8b
Compare
|
@rlhui are there other folks you'd like to have sign off on this? |
mikeberesford
force-pushed
the
port_debug
branch
from
8576a8b
to
d3b5914
Compare
JaiOCP
approved these changes
Feb 9, 2023
mikeberesford
force-pushed
the
port_debug
branch
from
d3b5914
to
59c4e2f
Compare
|
Spellcheck fixed (oops). |
|
@rlhui are there other signoffs we need to get this merged? |
|
@mikeberesford , would we please resolve conflicts? Thanks. |
Add a vendor-specific attribute to capture port debug data. The returned data should be a JSON-encoded string, containing the debug data. Signed-off-by: Mike Beresford <mberes@google.com>
mikeberesford
force-pushed
the
port_debug
branch
from
59c4e2f
to
dfb6594
Compare
|
@rlhui didn't notice that before, thanks. Rebased the change onto head and resolved the conflict. |
JaiOCP
pushed a commit
to JaiOCP/SAI
that referenced
this pull request
Mar 10, 2023
Add a vendor-specific attribute to capture port debug data. The returned data should be a JSON-encoded string, containing the debug data. Signed-off-by: Mike Beresford <mberes@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add simple attribute to get port debug data via the SAI interface. This is intended for vendor-specific debug information (ie SerDes/PHY information) that might be useful to debug a down/flaky port.