Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Constant Folding for ONNX Opset 12 #34823

Closed
wants to merge 1 commit into from
Closed

Enable Constant Folding for ONNX Opset 12 #34823

wants to merge 1 commit into from

Conversation

lara-hdr
Copy link
Contributor

Currently constant folding is only enabled for ONNX opset versions 9 to 11. This PR enables it for the new ONNX opset 12.

@lara-hdr lara-hdr requested a review from apaszke as a code owner March 16, 2020 18:38
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 16, 2020
@dr-ci
Copy link

dr-ci bot commented Mar 16, 2020 •
edited

💊 CircleCI build failures summary and remediations

As of commit d4f57c6 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 14 times.

@yf225 yf225 added module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Mar 20, 2020
neginraoof
neginraoof approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing slice as well :)

@KsenijaS
Copy link
Contributor

looks good

@lara-hdr
Copy link
Contributor Author

@houseroad this is approved

facebook-github-bot
facebook-github-bot reviewed Mar 24, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@houseroad
Copy link
Member

Please request my review or cc me, otherwise, I might not be aware it :-)

houseroad
houseroad approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@lara-hdr
Copy link
Contributor Author

@houseroad can we merge this?

@facebook-github-bot
Copy link
Contributor

@houseroad merged this pull request in 7e327e1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@neginraoof neginraoof neginraoof approved these changes

@houseroad houseroad houseroad approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees
No one assigned
Labels
Merged module: onnx Related to torch.onnx oncall: jit Add this issue/PR to JIT oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@lara-hdr @KsenijaS @houseroad @facebook-github-bot @neginraoof @yf225 @pytorchbot @mruberry