Fixes default dtype value for onnx hardtanh export (opset11) #35467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CircleCI build failures summary and remediationsAs of commit 4d5bd61 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
mruberry
added
the
triaged
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gchanan
pushed a commit
to gchanan/pytorch
that referenced
this pull request
Apr 7, 2020
…#35467) Summary: Oneline fix to lara-hdr 's PR pytorch#30169. Default `dtype` value should be set when `dtype is None` rather than when `dtype is not None`. I didn't make an issue for this as such a small change but I have been using this locally in order to export a model with opset 11 (opset 10 still works). Pull Request resolved: pytorch#35467 Differential Revision: D20686048 Pulled By: mruberry fbshipit-source-id: 726a5f9c0711c7a79b171fe98b602cdef27f9b31
|
This hasn't made it into 1.5.0 or 1.5.1. Will this be going into a release soon @mruberry? |
|
This will appear in the 1.6 release, which I think will be available in the next month or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oneline fix to @lara-hdr 's PR #30169.
Default
dtypevalue should be set whendtype is Nonerather than whendtype is not None.I didn't make an issue for this as such a small change but I have been using this locally in order to export a model with opset 11 (opset 10 still works).