Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONNX Update training ops and training amenable export API #35567

Closed
wants to merge 2 commits into from
Closed

ONNX Update training ops and training amenable export API #35567

wants to merge 2 commits into from

Conversation

lara-hdr
Copy link
Contributor

No description provided.

@lara-hdr
ONNX Update training ops and training amenable export API (pytorch#32950
748a8b4 
)

Summary:
- Update Dropout and Batchnorm in opset 12 : onnx/onnx#2568
- Update api logic for exporting to ONNX training amenable models
Pull Request resolved: pytorch#32950

Reviewed By: hl475

Differential Revision: D19710370

Pulled By: houseroad

fbshipit-source-id: e5e79d38552936966662c41d39ddf33be1ba3e35
@lara-hdr
fix expect
b4d61f6
@dr-ci
Copy link

dr-ci bot commented Mar 27, 2020 •
edited

💊 CircleCI build failures summary and remediations

As of commit b4d61f6 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | pattern match details) <confirmed not flaky by 2 failures>

Mar 27 15:41:56 FAIL [300.034s]: test_barrier_timeout_full_group (__main__.TestDistBackend) 
Mar 27 15:41:52   test_scatter_checks (__main__.TestDistBackend) ... ok (0.229s) 
Mar 27 15:41:52   test_scatter_full_group (__main__.TestDistBackend) ... ok (0.262s) 
Mar 27 15:41:54   test_scatter_group (__main__.TestDistBackend) ... ok (1.620s) 
Mar 27 15:41:54   test_send_recv (__main__.TestDistBackend) ... ok (0.320s) 
Mar 27 15:41:55   test_send_recv_any_source (__main__.TestDistBackend) ... ok (0.722s) 
Mar 27 15:41:55   test_send_recv_with_tag (__main__.TestDistBackend) ... ok (0.324s) 
Mar 27 15:41:56   test_sparse_all_reduce_sum (__main__.TestDistBackend) ... ok (0.314s) 
Mar 27 15:41:56   test_sparse_all_reduce_sum_cuda (__main__.TestDistBackend) ... skip (0.220s) 
Mar 27 15:41:56  
Mar 27 15:41:56 ====================================================================== 
Mar 27 15:41:56 FAIL [300.034s]: test_barrier_timeout_full_group (__main__.TestDistBackend) 
Mar 27 15:41:56 ---------------------------------------------------------------------- 
Mar 27 15:41:56 Traceback (most recent call last): 
Mar 27 15:41:56   File "distributed/test_distributed.py", line 2051, in wrapper 
Mar 27 15:41:56     self._join_and_reduce(fn) 
Mar 27 15:41:56   File "distributed/test_distributed.py", line 2144, in _join_and_reduce 
Mar 27 15:41:56     "Timeout waiting for rank %d to terminate" % rank) 
Mar 27 15:41:56 AssertionError: True is not false : Timeout waiting for rank 0 to terminate 
Mar 27 15:41:56  
Mar 27 15:41:56 ---------------------------------------------------------------------- 
Mar 27 15:41:56 Ran 94 tests in 370.580s
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 2 times.

facebook-github-bot
facebook-github-bot reviewed Mar 27, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@facebook-github-bot
Copy link
Contributor

@houseroad merged this pull request in 728c7dc.

@codemzs codemzs mentioned this pull request Apr 25, 2020
Closed
facebook-github-bot pushed a commit that referenced this pull request Apr 29, 2020
@codemzs @facebook-github-bot
Remove ONNX BatchNorm(12) test and converter. (#37309)
6c0f447 
Summary:
Pursuant to onnx/onnx#2750 we must remove PyTorch ONNX exporter related changes to BatchNorm(12) that were introduced as part of #35567. This change is also needed to unblock ONNX [BUILD CI failures](https://circleci.com/gh/onnx/onnx/4629?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) caused by PyTorch/Caffe2 tests.
Pull Request resolved: #37309

Reviewed By: hl475

Differential Revision: D21288914

Pulled By: houseroad

fbshipit-source-id: 15b076a2af55918dcd57f4e2fc77accd3d1510bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad houseroad approved these changes

Assignees
No one assigned
Labels
Merged open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lara-hdr @facebook-github-bot @houseroad @pytorchbot @mruberry