[ONNX] Improve error checking for large model export #37798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BowenBao
commented
May 4, 2020
BowenBao
commented
- Add error message when onnx model file path is not a string.
- Add error message when model size exceed 2GB when large model export is not turned on.
facebook-github-bot
added
the
oncall: jit
ngimel
added
the
triaged
houseroad
reviewed
May 6, 2020
| @@ -957,6 +964,11 @@ std::tuple<std::string, RawDataExportMap> export_onnx( | |||
| add_node_names, | |||
| use_external_data_format, | |||
| onnx_file_path); | |||
| const size_t proto_size = graph_encoder.get_model_proto().ByteSizeLong(); | |||
There was a problem hiding this comment.
I am wondering whether model_proto will be larger than 2GB, or just directly truncated when dumping to string.
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@houseroad merged this pull request in 122587d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.