[ONNX] Enable tests for opset 12 #37846
Conversation
💊 CI failures summary and remediationsAs of commit b792f48 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 21 times. |
neginraoof
changed the title
neginraoof
changed the title
| @@ -1498,7 +1482,11 @@ def forward(self, x): | |||
| def test_topk_smallest_unsorted(self): | |||
| class MyModule(torch.nn.Module): | |||
| def forward(self, x, k): | |||
| return torch.topk(x, k, largest=False, sorted=False) | |||
| # When sorted=False, order of elements in the outout tensors | |||
There was a problem hiding this comment.
This is a change in behavior in the newest ORT build, but it is expected (not a bug).
There was a problem hiding this comment.
are we planning on supporting this case?
There was a problem hiding this comment.
We do support this case, but since the output tensor is not sorted (sorted=False), the order of elements in ORT output tensor is different from PyTorch output. This is expected.
| @@ -1498,7 +1482,11 @@ def forward(self, x): | |||
| def test_topk_smallest_unsorted(self): | |||
| class MyModule(torch.nn.Module): | |||
| def forward(self, x, k): | |||
| return torch.topk(x, k, largest=False, sorted=False) | |||
| # When sorted=False, order of elements in the outout tensors | |||
There was a problem hiding this comment.
are we planning on supporting this case?
|
@houseroad Can you please review this? |
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@houseroad merged this pull request in 29f19bf. |
* [ONNX] Fix pow op export (#38065) Summary: Fix pow type cast for opset 9 and update opset 12 Pull Request resolved: #38065 Differential Revision: D21485353 Pulled By: malfet fbshipit-source-id: 3993e835ffad07b2e6585eb5cf1cb7c8474de2ec * Update ort-nighly version as suggested in #39685 (comment) * Apply changes from #37846 to `test_topk_smallest_unsorted` Co-authored-by: neginraoof <neginmr@utexas.edu>
Update ORT nightly version and enable opset 12 tests.